8354471: Assertion failure with -XX:-EnableX86ECoreOpts

[vpaprotsk]

The check to choose between AVX2 and AVX512 implementation was relying on EnableX86ECoreOpts. It should be relying on supports_avxifma and mirror the UseIntPolyIntrinsics check in vm_version_x86.cpp.

Note, in stubGenerator_x86_64.cpp, entry to the patched function is protected already:

  if (UseIntPolyIntrinsics) {
    StubRoutines::_intpoly_montgomeryMult_P256 = generate_intpoly_montgomeryMult_P256();
    StubRoutines::_intpoly_assign = generate_intpoly_assign();
  }

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354471: Assertion failure with -XX:-EnableX86ECoreOpts (Bug - P3)

Reviewers

• Sandhya Viswanathan (@sviswa7 - Reviewer)
• Jatin Bhateja (@jatin-bhateja - Reviewer) Review applies to ee1b099f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24644/head:pull/24644
$ git checkout pull/24644

Update a local copy of the PR:
$ git checkout pull/24644
$ git pull https://git.openjdk.org/jdk.git pull/24644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24644

View PR using the GUI difftool:
$ git pr show -t 24644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24644.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vpaprotski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vpaprotsk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354471: Assertion failure with -XX:-EnableX86ECoreOpts

Reviewed-by: sviswanathan, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 98dac46: 8353589: Open source a few Swing menu-related tests
• e433fa2: 8352001: AOT cache should not contain classes injected into built-in class loaders
• d80db00: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI
• ... and 38 more: https://git.openjdk.org/jdk/compare/c7b70a138ff592fdf1cd4f1d063103491a8aa7db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vpaprotsk The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (60f00320)
• 01: Full - Incremental (ee1b099f)
• 00: Full (0ad246c6)

[jatin-bhateja]

As per the latest architecture-instruction-set-extensions-programming-reference document, the upcoming Diamond Rapdis CPU has AVX-IFMA but its also a P-Core Xeon with 512 bit flavour of IFMA, do you think it is performant to generate montgomeryMultiplyAVX2 for it ?

[vpaprotsk]

Thanks for spotting this! I was wondering about this if statement being 'future-proof'.. I think its best to just flip the order of the if to prefer the AVX512 when available (it will make the diff look bigger, which is why I originally avoided it..)

[sviswa7]

Looks good to me.

[vpaprotsk]

If there are no objections, will integrate later today

[jatin-bhateja]

Minor comment modification suggestion.
Otherwise looks good.

[vpaprotsk]

/integrate

[openjdk]

@vpaprotsk
Your change (at version 60f0032) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit 0c34bf0.
Since your change was applied there have been 41 commits pushed to the master branch:

• 98dac46: 8353589: Open source a few Swing menu-related tests
• e433fa2: 8352001: AOT cache should not contain classes injected into built-in class loaders
• d80db00: 8354873: javax/swing/plaf/metal/MetalIconFactory/bug4952462.java failing on CI
• ... and 38 more: https://git.openjdk.org/jdk/compare/c7b70a138ff592fdf1cd4f1d063103491a8aa7db...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @vpaprotsk Pushed as commit 0c34bf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.