Skip to content

8353445: Open source several AWT Menu tests - Batch 1 #24649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Apr 15, 2025

Open source these AWT Menu tests:

java/awt/Menu/MenuVisibilityTest/MenuVisibilityTest.java
java/awt/Menu/MenuActionEventTest/MenuActionEventTest.java
java/awt/Menu/RmInHideTest/RmInHideTest.java
java/awt/Menu/SetShortCutTest/SetShortCutTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353445: Open source several AWT Menu tests - Batch 1 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24649/head:pull/24649
$ git checkout pull/24649

Update a local copy of the PR:
$ git checkout pull/24649
$ git pull https://git.openjdk.org/jdk.git pull/24649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24649

View PR using the GUI difftool:
$ git pr show -t 24649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24649.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2025

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353445: Open source several AWT Menu tests - Batch 1

Reviewed-by: abhiscxk, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 18, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@TejeshR13 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout branch_8353445
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 22, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Apr 22, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2025
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 22, 2025

Going to push as commit 367bcc5.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7eab2d9: 8354095: Open some JTable bugs 5

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2025
@openjdk openjdk bot closed this Apr 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2025
@openjdk
Copy link

openjdk bot commented Apr 22, 2025

@TejeshR13 Pushed as commit 367bcc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants