-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8356556: AArch64: No need for acquire fence in safepoint poll in FFM #25211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @spchee, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user spchee" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
❗ This change is not yet ready to be integrated. |
@spchee this pull request can not be integrated into git checkout safepoint_acq
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@spchee This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@spchee The pull request is being re-evaluated and the inactivity timeout has been reset. |
Removes the unnecessary acquire to reduce memory ordering requirement since it is not longer needed as threads always disarm their own poll value.
Progress
Error
Warnings
Issue
Backport <hash>
with the hash of the original commit. See Backports.Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25211/head:pull/25211
$ git checkout pull/25211
Update a local copy of the PR:
$ git checkout pull/25211
$ git pull https://git.openjdk.org/jdk.git pull/25211/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25211
View PR using the GUI difftool:
$ git pr show -t 25211
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25211.diff