-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8346884: Add since checker test to jdk.editpad #25613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8346884: Add since checker test to jdk.editpad #25613
Conversation
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add core-libs |
I realize there are no classfiles in The goal is to have an |
@nizarbenalla |
@nizarbenalla |
Please review this patch to add a new test to check
@since
tags in thejdk.editpad
module.TIA
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25613/head:pull/25613
$ git checkout pull/25613
Update a local copy of the PR:
$ git checkout pull/25613
$ git pull https://git.openjdk.org/jdk.git pull/25613/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25613
View PR using the GUI difftool:
$ git pr show -t 25613
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25613.diff
Using Webrev
Link to Webrev Comment