Skip to content

8346884: Add since checker test to jdk.editpad #25613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Jun 3, 2025

Please review this patch to add a new test to check @since tags in the jdk.editpad module.

TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346884: Add since checker test to jdk.editpad (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25613/head:pull/25613
$ git checkout pull/25613

Update a local copy of the PR:
$ git checkout pull/25613
$ git pull https://git.openjdk.org/jdk.git pull/25613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25613

View PR using the GUI difftool:
$ git pr show -t 25613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25613.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla nizarbenalla marked this pull request as ready for review June 3, 2025 11:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2025
@nizarbenalla
Copy link
Member Author

/label add core-libs
/label add kulla

@nizarbenalla
Copy link
Member Author

nizarbenalla commented Jun 3, 2025

I realize there are no classfiles in jdk.editpad but the test can also check the @since information in the module-info.java file.

The goal is to have an @since test per module.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla
The kulla label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant