8356751: IGV: clean up redundant field _should_send_method

[benoitmaillard]

This PR removes private field IdealGraphPrinter::_should_send_method (as it was only ever assigned true) and all usages in conditions.

Testing

• GitHub Actions
• tier1, and some Oracle internal testing
• Ran IdealGraphVisualizer and made sure that no crash occured

Shout out to @mhaessig for introducing me to IGV

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356751: IGV: clean up redundant field _should_send_method (Enhancement - P5)

Reviewers

• Manuel Hässig (@mhaessig - Author)
• Tobias Hartmann (@TobiHartmann - Reviewer)
• Damon Fenacci (@dafedafe - Committer)

Contributors

• Manuel Hässig <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25714/head:pull/25714
$ git checkout pull/25714

Update a local copy of the PR:
$ git checkout pull/25714
$ git pull https://git.openjdk.org/jdk.git pull/25714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25714

View PR using the GUI difftool:
$ git pr show -t 25714

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25714.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back benoitmaillard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[benoitmaillard]

/contributor add @mhaessig

[openjdk]

@benoitmaillard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356751: IGV: clean up redundant field _should_send_method

Co-authored-by: Manuel Hässig <[email protected]>
Reviewed-by: mhaessig, thartmann, dfenacci

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 56ce70c: 8359165: AIX build broken after 8358799
• abc76c6: 8359126: [AIX] new test TestImplicitNullChecks.java fails
• 9586817: 8359170: Add 2 TLS and 2 CS Sectigo roots
• ... and 6 more: https://git.openjdk.org/jdk/compare/7c9c8ba363521a7bfb58e1a8285459f717769889...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @dafedafe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@benoitmaillard
Contributor Manuel Hässig <[email protected]> successfully added.

[openjdk]

@benoitmaillard The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2a1ac442)

[mhaessig]

Thank you for working on this and also for the credit 🙂

This looks good to me.

[TobiHartmann]

Looks good to me too.

[dafedafe]

Looks good to me too!
Thanks a lot @benoitmaillard!

[benoitmaillard]

/integrate

[openjdk]

@benoitmaillard
Your change (at version 2a1ac44) is now ready to be sponsored by a Committer.

[dafedafe]

/sponsor

[openjdk]

Going to push as commit bf7d40d.
Since your change was applied there have been 10 commits pushed to the master branch:

• 5ae32c4: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty
• 56ce70c: 8359165: AIX build broken after 8358799
• abc76c6: 8359126: [AIX] new test TestImplicitNullChecks.java fails
• ... and 7 more: https://git.openjdk.org/jdk/compare/7c9c8ba363521a7bfb58e1a8285459f717769889...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dafedafe @benoitmaillard Pushed as commit bf7d40d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.