-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8359024: Accessibility bugs in API documentation #25716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 244 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 9a726df.
Your commit was automatically rebased without conflicts. |
/backport :jdk25 |
@hns the backport was successfully created on the branch backport-hns-9a726df3-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing.
Contrast between link and normal text colors was below 3 and therefore would have required other styling (such as underlining). This is fixed by slightly darkening text color (our text color isn't black but dark-gray).
Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=282828&bcolor=FFFFFF&lcolor=437291
New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=FFFFFF&lcolor=437291
Links in the headings of inherited member summaries used the wrong color and contrast to background color was below 4.5. This is fixed by removing a bogus
.expanded
selector that shouldn't have been there in the first place.Old colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=437291
New colors: https://webaim.org/resources/linkcontrastchecker/?fcolor=181818&bcolor=DEE3E9&lcolor=47688A
Remove the
role="tablist"
andaria-orientation="horizontal"
attributes from table captions if they do not contain tabs. This is the only code change, and the only change that comes with a test change (I guess the CSS changes arenoreg-hard
as we don't have a way to do automatic accessibility testing).All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25716/head:pull/25716
$ git checkout pull/25716
Update a local copy of the PR:
$ git checkout pull/25716
$ git pull https://git.openjdk.org/jdk.git pull/25716/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25716
View PR using the GUI difftool:
$ git pr show -t 25716
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25716.diff
Using Webrev
Link to Webrev Comment