Skip to content

8359024: Accessibility bugs in API documentation #25716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hns
Copy link
Member

@hns hns commented Jun 10, 2025

Please review a change to fix a couple of accessibility errors in JDK API documentation as detected by our accessibility testing.

All changes are invisible or so subtle that they are practically impossible to spot in normal browsing, so I spare myself the task of uploading demo docs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359024: Accessibility bugs in API documentation (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25716/head:pull/25716
$ git checkout pull/25716

Update a local copy of the PR:
$ git checkout pull/25716
$ git pull https://git.openjdk.org/jdk.git pull/25716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25716

View PR using the GUI difftool:
$ git pr show -t 25716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25716.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359024: Accessibility bugs in API documentation

Reviewed-by: vyazici, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 244 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8359024: Accessibility bugs in API documentation 8359024: Accessibility bugs in API documentation Jun 10, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2025
@hns
Copy link
Member Author

hns commented Jun 24, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

Going to push as commit 9a726df.
Since your change was applied there have been 244 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2025
@openjdk openjdk bot closed this Jun 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@hns Pushed as commit 9a726df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@hns
Copy link
Member Author

hns commented Jun 24, 2025

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@hns the backport was successfully created on the branch backport-hns-9a726df3-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 9a726df3 from the openjdk/jdk repository.

The commit being backported was authored by Hannes Wallnöfer on 24 Jun 2025 and was reviewed by Volkan Yazici and Chen Liang.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-hns-9a726df3-jdk25:backport-hns-9a726df3-jdk25
$ git checkout backport-hns-9a726df3-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-hns-9a726df3-jdk25

⚠️ @hns You are not yet a collaborator in my fork openjdk-bots/jdk. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants