Skip to content

8359110: Log accumulated GC and process CPU time upon VM exit #25724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

JonasNorlinder
Copy link
Contributor

@JonasNorlinder JonasNorlinder commented Jun 10, 2025

Add support to log CPU cost for GC during VM exit with -Xlog:gc.

[1.500s][info ][gc] GC CPU cost: 1.75%

Additionally, detailed information may be retrieved with -Xlog:gc=trace

[1.500s][trace][gc] Process CPU time: 4.945370s
[1.500s][trace][gc] GC CPU time: 0.086382s
[1.500s][info ][gc] GC CPU cost: 1.75%

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359110: Log accumulated GC and process CPU time upon VM exit (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25724/head:pull/25724
$ git checkout pull/25724

Update a local copy of the PR:
$ git checkout pull/25724
$ git pull https://git.openjdk.org/jdk.git pull/25724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25724

View PR using the GUI difftool:
$ git pr show -t 25724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25724.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

👋 Welcome back JonasNorlinder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@JonasNorlinder The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

@JonasNorlinder
Copy link
Contributor Author

/label add hotspot-gc

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@JonasNorlinder
The hotspot-gc label was successfully added.

@JonasNorlinder JonasNorlinder marked this pull request as draft June 11, 2025 10:06
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 11, 2025
@JonasNorlinder JonasNorlinder force-pushed the gc_cpu_time branch 4 times, most recently from b592df0 to ada4cda Compare June 12, 2025 10:22
@JonasNorlinder
Copy link
Contributor Author

/label add runtime

@openjdk
Copy link

openjdk bot commented Jun 12, 2025

@JonasNorlinder
The label runtime is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@JonasNorlinder
Copy link
Contributor Author

/label add hotspot-runtime

@openjdk
Copy link

openjdk bot commented Jun 12, 2025

@JonasNorlinder
The hotspot-runtime label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants