Skip to content

8359120: Improve warning message when fail to load hsdis library #25726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −0
Open

8359120: Improve warning message when fail to load hsdis library #25726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9321f4b
Improve hsdis load error message
kurashige23 Jun 9, 2025
c01de1d
Merge branch 'openjdk:master' into hsdis_load_err_msg
kurashige23 Jun 10, 2025
45584ba
Remove include of log.hpp
kurashige23 Jun 10, 2025
6ff4f9b
Fix message and revert lines for Xlog
kurashige23 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/hotspot/share/code/nmethod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3488,6 +3488,9 @@ void nmethod::decode2(outputStream* ost) const {
if (use_compressed_format && ! compressed_with_comments) {
const_cast<nmethod*>(this)->print_constant_pool(st);

st->bol();
st->cr();
st->print_cr("Loading hsdis library failed, undisassembled code is shown in MachCode section");
//---< Open the output (Marker for post-mortem disassembler) >---
st->print_cr("[MachCode]");
const char* header = nullptr;
Expand Down Expand Up @@ -3522,6 +3525,9 @@ void nmethod::decode2(outputStream* ost) const {
if (compressed_with_comments) {
const_cast<nmethod*>(this)->print_constant_pool(st);

st->bol();
st->cr();
st->print_cr("Loading hsdis library failed, undisassembled code is shown in MachCode section");
//---< Open the output (Marker for post-mortem disassembler) >---
st->print_cr("[MachCode]");
while ((p < end) && (p != nullptr)) {
Expand Down
3 changes: 3 additions & 0 deletions src/hotspot/share/compiler/abstractDisassembler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ void AbstractDisassembler::decode_abstract(address start, address end, outputStr

outputStream* st = (ost == nullptr) ? tty : ost;

st->bol();
st->cr();
st->print_cr("Loading hsdis library failed, undisassembled code is shown in MachCode section");
//---< Open the output (Marker for post-mortem disassembler) >---
st->bol();
st->print_cr("[MachCode]");
Expand Down