Skip to content

8359170: Add 2 TLS and 2 CS Sectigo roots #25736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Jun 10, 2025

Hi all,

This pull request contains a backport of commit 9586817c from the openjdk/jdk repository.

The commit being backported was authored by Rajan Halade on 10 Jun 2025 and was reviewed by Sean Mullan.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359170: Add 2 TLS and 2 CS Sectigo roots (Enhancement - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25736/head:pull/25736
$ git checkout pull/25736

Update a local copy of the PR:
$ git checkout pull/25736
$ git pull https://git.openjdk.org/jdk.git pull/25736/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25736

View PR using the GUI difftool:
$ git pr show -t 25736

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25736.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359170: Add 2 TLS and 2 CS Sectigo roots

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9586817cea3f1cad8a49d43e9106e25dafa04765 8359170: Add 2 TLS and 2 CS Sectigo roots Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2025
@rhalade
Copy link
Member Author

rhalade commented Jun 17, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

Going to push as commit ae71782.
Since your change was applied there have been 14 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2025
@openjdk openjdk bot closed this Jun 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@rhalade Pushed as commit ae71782.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants