8359181: Error messages generated by configure --help after 8301197

[sendaoYan]

Hi all,

The macro HELP_PRINT_ADDITIONAL_HELP_AND_EXIT is only called directly from make/autoconf/configure. In JDK-8301197, most uses of printf was changed to echo, but this explicit call wasn't updated to also set ECHO=echo, this PR add ECHO=echo when call this macro.

Change has been verified locally, almost no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359181: Error messages generated by configure --help after 8301197 (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25740/head:pull/25740
$ git checkout pull/25740

Update a local copy of the PR:
$ git checkout pull/25740
$ git pull https://git.openjdk.org/jdk.git pull/25740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25740

View PR using the GUI difftool:
$ git pr show -t 25740

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25740.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359181: Error messages generated by configure --help after 8301197

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• bf7d40d: 8356751: IGV: clean up redundant field _should_send_method
• 5ae32c4: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty
• 56ce70c: 8359165: AIX build broken after 8358799
• ... and 1 more: https://git.openjdk.org/jdk/compare/9586817cea3f1cad8a49d43e9106e25dafa04765...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ede9e55b)
• 00: Full (ffbd770f)

[erikj79]

This does not seem like the correct solution. This macro is only called directly from make/autoconf/configure, which is our wrapper script around the autoconf generated scripts. That wrapper expects this macro to be using printf so it sets PRINTF=printf on the command line:

jdk/make/autoconf/configure

Line 369 in 9586817

( CONFIGURE_PRINT_ADDITIONAL_HELP=true . $generated_script PRINTF=printf )

In JDK-8301197, we changed most uses of printf to echo, but this explicit call wasn't updated to also set ECHO=echo. Doing that fixes the issue.

[erikj79]

I think this looks good, but please give Magnus a chance to review as his opinion may differ and this is more of his area than mine.

[sendaoYan]

In JDK-8301197, we changed most uses of printf to echo, but this explicit call wasn't updated to also set ECHO=echo. Doing that fixes the issue.

@erikj79 Thanks your correction, I have revert the original commit and add ECHO=echo when call the mcaro, the PR description also updated.

[magicus]

This looks like the proper solution.

Thanks for finding and fixing.

[sendaoYan]

Thanks @magicus @erikj79 for the reviews and suggestions.

/integrate

[openjdk]

Going to push as commit 7b7136b.
Since your change was applied there have been 15 commits pushed to the master branch:

• 5886ef7: 8359182: Use @requires instead of SkippedException for MaxPath.java
• d7aa349: 8357826: Avoid running some jtreg tests when asan is configured
• 3b32f6a: 8344556: [Graal] compiler/intrinsics/bmi/* fail when AOTCache cannot be loaded
• ... and 12 more: https://git.openjdk.org/jdk/compare/9586817cea3f1cad8a49d43e9106e25dafa04765...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 7b7136b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.