Skip to content

8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java #25785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8359167: Remove unused test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java #25785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dc4e5
Remove unused BindServer and update comments related to remote and ma…
plummercj Jun 12, 2025
ed0999c
Update test/hotspot/jtreg/vmTestbase/nsk/share/jpda/IOPipe.java
plummercj Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -32,7 +32,7 @@

/**
* This class provides launching of <code>jdb</code> and debuggee in local
* or remote mode according to test command line options.
* mode according to test command line options.
Comment on lines 34 to +35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As now there is only local mode, I think there is no sense to mention it at all:

 * This class provides launching of <code>jdb</code> and debuggee
 * according to test command line options.

*/

public class Launcher extends DebugeeBinder {
Expand Down Expand Up @@ -94,7 +94,7 @@ public Launcher (JdbArgumentHandler argumentHandler, Log log) {
}

/**
* Defines mode (local or remote) and type of connector (default, launching,
* Defines mode (local) and type of connector (default, launching,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Defines mode (local) and type of connector (default, launching,
* Defines type of connector (default, launching,

* raw launching, attaching or listening) according to options
* parsed by <code>JdbArgumentHandler</code>. And then launches <code>jdb</code>
* and debuggee in defined mode.
Expand Down
Loading