Skip to content

8354872: Clarify java.lang.Process resource cleanup #25884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jun 18, 2025

Improve the documentation of Process use of system resources.

Describe the implementation closing streams when no longer referenced.
Clarify the interactions between inputStream and inputReader and errorStream and errorReader.
Add advice and example using try-with-resources to open and close streams.
Recommend closing streams when no longer in use.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8356311 to be approved

Issues

  • JDK-8354872: Clarify java.lang.Process resource cleanup (Bug - P4)
  • JDK-8356311: Clarify java.lang.Process resource cleanup (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25884/head:pull/25884
$ git checkout pull/25884

Update a local copy of the PR:
$ git checkout pull/25884
$ git pull https://git.openjdk.org/jdk.git pull/25884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25884

View PR using the GUI difftool:
$ git pr show -t 25884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25884.diff

Using Webrev

Link to Webrev Comment

Recommend closing streams when no longer in use.
Describe the implementation closing streams when no longer referenced.
Clarify the interactions between inputStream and inputReader and
errorStream and errorReader.
Add advice and example using try-with-resources to open and close streams.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 18, 2025
@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant