8360522: G1: Flag constraint functions for G1SATBBufferSize and G1UpdateBufferSize are skipped during argument validation

[walulyai]

Hi,

Please review this change to move constraint function execution for G1SATBBufferSize and G1UpdateBufferSize to AfterErgo. These functions rely on the UseG1GC flag to determine whether to apply checks. However, during the AtParse phase of argument handling, UseG1GC may not yet be processed, which causes the constraints to be skipped.

Testing:
java -XX:G1SATBBufferSize=0 -version
G1SATBBufferSize (0) must be in range [1, 4294967295]
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360522: G1: Flag constraint functions for G1SATBBufferSize and G1UpdateBufferSize are skipped during argument validation (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) Review applies to e4efe8de
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25979/head:pull/25979
$ git checkout pull/25979

Update a local copy of the PR:
$ git checkout pull/25979
$ git pull https://git.openjdk.org/jdk.git pull/25979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25979

View PR using the GUI difftool:
$ git pr show -t 25979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25979.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360522: G1: Flag constraint functions for G1SATBBufferSize and G1UpdateBufferSize are skipped during argument validation

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 5a1301d: 8360548: Parallel: Remove outdated comments in MutableNUMASpace::bias_region
• 5039b42: 8359437: Make users and test suite not able to set LockingMode flag
• 1ca008f: 8360255: runtime/jni/checked/TestLargeUTF8Length.java fails with -XX:-CompactStrings
• ... and 10 more: https://git.openjdk.org/jdk/compare/1fa090524a7c3bb5f2c92fb0f7217b9277ade9d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@walulyai The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0ebf48bb)
• 00: Full (e4efe8de)

[sendaoYan]

Should we update the copyrighy year from 2024 to 2025

[walulyai]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit bd666f9.
Since your change was applied there have been 17 commits pushed to the master branch:

• a0c3efa: 8359947: GenShen: use smaller TLABs by default
• 7576064: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java
• 8df6b2c: 8359830: Incorrect os.version reported on macOS Tahoe 26 (Beta)
• ... and 14 more: https://git.openjdk.org/jdk/compare/1fa090524a7c3bb5f2c92fb0f7217b9277ade9d9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@walulyai Pushed as commit bd666f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.