Skip to content

8322920: Some ProcessTools.execute* functions are declared to throw Throwable #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 21, 2025

Hi all,

This pull request contains a backport of commit 5fd79e96 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 19 Mar 2024 and had no reviewers.

Thanks!


Progress

  • JDK-8322920 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322920: Some ProcessTools.execute* functions are declared to throw Throwable (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3025/head:pull/3025
$ git checkout pull/3025

Update a local copy of the PR:
$ git checkout pull/3025
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3025

View PR using the GUI difftool:
$ git pr show -t 3025

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3025.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5fd79e961dc370b312e7828a7d1bcc159a0e8635 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant