Skip to content

8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2025

Backport of JDK-8357793. Version from jdk21u-dev applies cleanly, but InterpreterMacroAssembler::load_klass_check_null_throw didn't exist in 17u. I've taken the PPC64 interpreter parts from openjdk/jdk@7cf7e0a.

Testing:
make run-test TEST=hotspot:tier1 JTREG="VM_OPTIONS=-XX:-UseSIGTRAP -XX:-ImplicitNullChecks" has passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8357793 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3619/head:pull/3619
$ git checkout pull/3619

Update a local copy of the PR:
$ git checkout pull/3619
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3619

View PR using the GUI difftool:
$ git pr show -t 3619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3619.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fef4c29e5a296c0c689abb25183c243326607614 8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK17 is affected by this bug. Backport reason and risk are the same as in the jdk21u-fix-request. The version from 21u applies cleanly, but required a trivial addition which has been reviewed.

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

@TheRealMDoerr
8357793: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 11, 2025
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

Going to push as commit 3ee1839.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 16, 2025
@openjdk openjdk bot closed this Jun 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2025
@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@TheRealMDoerr Pushed as commit 3ee1839.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8357793_PPC64_mh_dispatch_exception_entry branch June 16, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants