Skip to content

8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 5, 2025

Backport of JDK-8357793. Version from jdk21u-dev applies cleanly, but InterpreterMacroAssembler::load_klass_check_null_throw didn't exist in 17u. I've taken the PPC64 interpreter parts from openjdk/jdk@7cf7e0a.

Testing:
make run-test TEST=hotspot:tier1 JTREG="VM_OPTIONS=-XX:-UseSIGTRAP -XX:-ImplicitNullChecks" has passed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8357793 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3619/head:pull/3619
$ git checkout pull/3619

Update a local copy of the PR:
$ git checkout pull/3619
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3619

View PR using the GUI difftool:
$ git pr show -t 3619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3619.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fef4c29e5a296c0c689abb25183c243326607614 8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK17 is affected by this bug. Backport reason and risk are the same as in the jdk21u-fix-request. The version from 21u applies cleanly, but required a trivial addition which has been reviewed.

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

@TheRealMDoerr
8357793: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants