Skip to content

8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: pr/1660
Choose a base branch
from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Apr 16, 2025

A patch 3 of 6 for: [21u] Backport intention of 8322420: [Linux] cgroup v2: Limits in parent nested control groups are not detected

It has a patch dependency on PR 2 of 6: #1660

This backport is clean. But it contains an additional oneliner (by Yuri Nesterenko):

make/data/hotspot-symbols/symbols-linux:
+JVM_IsContainerized

as otherwise the build would fail with:

src/java.base/linux/native/libjava/CgroupMetrics.c:42:(.text+0x11): undefined reference to `JVM_IsContainerized'

This oneliner was not needed in JDK24 as there is JDK-8017234: Hotspot should stop using mapfiles.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8261242 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1660 must be integrated first

Issue

  • JDK-8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1661/head:pull/1661
$ git checkout pull/1661

Update a local copy of the PR:
$ git checkout pull/1661
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1661

View PR using the GUI difftool:
$ git pr show -t 1661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1661.diff

Using Webrev

Link to Webrev Comment

Jan Kratochvil and others added 2 commits April 14, 2025 15:54
…ndefined reference to `JVM_IsContainerized'

 - a patch by Yuri Nesterenko
…n outside a container

Reviewed-by: stuefe, iklam
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/1660 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 18cffb604a5f56ef59e56840f2bb9fd27f8485db 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 16, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants