Skip to content

8313804: JDWP support for -Djava.net.preferIPv6Addresses=system #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Larry-N
Copy link

@Larry-N Larry-N commented May 12, 2025

Clean backport. Testing with tier1 on alpine linux in progress.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313804 needs maintainer approval

Issue

  • JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1773/head:pull/1773
$ git checkout pull/1773

Update a local copy of the PR:
$ git checkout pull/1773
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1773

View PR using the GUI difftool:
$ git pr show -t 1773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1773.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2025

👋 Welcome back inakonechnyy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9291b46bcfa76a596578eb50c29b9850e7020dea 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system May 12, 2025
@openjdk
Copy link

openjdk bot commented May 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 12, 2025
@mlbridge
Copy link

mlbridge bot commented May 12, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented May 14, 2025

Hi @Larry-N
Can you please justify why you want to backport this, especially to 17?
It seems a day zero issue, and I think it's rather an enhancement than a bug.
Also, can you please have a look at https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
and also revisit your other backports?
Thanks!

@openjdk
Copy link

openjdk bot commented May 16, 2025

⚠️ @Larry-N This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval label May 16, 2025
@Larry-N
Copy link
Author

Larry-N commented May 16, 2025

@GoeLin, The jtreg test com/sun/jdi/JdwpListenTest.java failing "ERROR: failed to attach" on linux-musl builds, for jdk21 and jdk17.
For the jdk24, the test passes smoothly.
It is both 8313804 and 8317804 that if applied together (since jdk23), solve the problem.
In jdk21 the 8317804 was already backported.
For jdk17 both of the fixes are absent.

@openjdk openjdk bot added the approval label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants