8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

[satyenme]

Backporting JDK-8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp. HotSpot VM build macro only defines _WINDOWS env variable (not WINDOWS). call_clobbered_gp_registers() and call_clobbered_xmm_registers() use the wrong variable name. Leads to RSI and RDI missing from list of clobbered register on windows, and may cause issue when calling native code which modifies them. Ran GHA Sanity Checks and local Tier 1 and 2 (though not on a Windows machine). Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8343452 needs maintainer approval

Issue

• JDK-8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1848/head:pull/1848
$ git checkout pull/1848

Update a local copy of the PR:
$ git checkout pull/1848
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1848

View PR using the GUI difftool:
$ git pr show -t 1848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1848.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 416241b: 8351491: Add info from release file to hserr file
• 11ffcd5: 8353568: SEGV_BNDERR signal code adjust definition
• 2ac7476: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
• ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/c7409c79614a0693694e979065205bd847a5bee9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (5d4d3145)

[satyenme]

/approval request for backport of JDK-8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

Motivation: Without this backport, current code uses incorrect variable name, which could lead to RSI and RDI missing from list of clobbered register on windows and may cause issues when calling native code which modifies them. With the backport, we preclude this scenario, without breaking existing logic.

Risk: Low. Ran GHA Sanity Checks and local Tier 1 and 2 (though not on a Windows machine). Patch is clean. Change has been present in tip since November, 2024.

[openjdk]

@satyenme usage: /approval [<id>] (request|cancel) [<text>]

[satyenme]

/approval request for backport of JDK-8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

Motivation: Without this backport, current code uses incorrect variable name, which could lead to RSI and RDI missing from list of clobbered register on windows and may cause issues when calling native code which modifies them. With the backport, we preclude this scenario, without breaking existing logic.

Risk: Low. Ran GHA Sanity Checks and local Tier 1 and 2 (though not on a Windows machine). Patch is clean. Change has been present in tip since November, 2024.

[openjdk]

@satyenme
8343452: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

Going to push as commit 5cc193f.
Since your change was applied there have been 13 commits pushed to the master branch:

• a71783b: 8314978: Multiple server call from connection failing with expect100 in getOutputStream
• edd4120: 8347826: Introspector shows wrong method list after 8071693
• 3445b99: 8354941: Build failure with glibc 2.42 due to uabs() name collision
• ... and 10 more: https://git.openjdk.org/jdk21u-dev/compare/c7409c79614a0693694e979065205bd847a5bee9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@satyenme Pushed as commit 5cc193f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.