Skip to content

8293107: GHA: Bump to Ubuntu 22.04 #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Feb 25, 2025

Updates GHA workflow to Ubuntu 22.04.

Notes:

  • code changes were done manually here (GHA workflows were rewritten in newer JDKs)
  • Ubuntu 20.04 runner image for GHA is already deprecated and will be unsupported soon
  • sysroot update to bullseye was already done separately (update to ubuntu 22.04 was not done at the time, it was blocked by JDK-8281096 )

Testing:
tier1 in GHA: OK

Failures:


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8293107 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293107: GHA: Bump to Ubuntu 22.04 (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/628/head:pull/628
$ git checkout pull/628

Update a local copy of the PR:
$ git checkout pull/628
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/628/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 628

View PR using the GUI difftool:
$ git pr show -t 628

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/628.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293107: GHA: Bump to Ubuntu 22.04

Reviewed-by: andrew, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@zzambers zzambers changed the title GHA: update to ubuntu 22.04 and bullseye sysroot 8293107: GHA: update to ubuntu 22.04 and bullseye sysroot Feb 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 25, 2025
@zzambers zzambers changed the title 8293107: GHA: update to ubuntu 22.04 and bullseye sysroot 8293107: GHA: Bump to Ubuntu 22.04 Feb 25, 2025
@zzambers zzambers changed the title 8293107: GHA: Bump to Ubuntu 22.04 Backport d7536588b38e368eaa6395bcbcc6724a39303fc5 Feb 25, 2025
@openjdk openjdk bot changed the title Backport d7536588b38e368eaa6395bcbcc6724a39303fc5 8293107: GHA: Bump to Ubuntu 22.04 Feb 25, 2025
@openjdk
Copy link

openjdk bot commented Feb 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. As you say, we already have the bullseye change and we got rid of the specific compiler versioning a long time ago.

This broke today (just in time for the release!) so we should get this in ASAP. Please apply for approval.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@zzambers
Copy link
Contributor Author

/approval request Bump of Ubuntu in GHA to 22.04, safe, only affects testing in GHA

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@zzambers
8293107: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 16, 2025
@zzambers
Copy link
Contributor Author

This broke today (just in time for the release!) so we should get this in ASAP. Please apply for approval.

done

@jerboaa
Copy link
Contributor

jerboaa commented Apr 17, 2025

/approve yes

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@jerboaa
8293107: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 17, 2025
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

Going to push as commit 55273f7.
Since your change was applied there have been 31 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025
@openjdk openjdk bot closed this Apr 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@zzambers Pushed as commit 55273f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants