Skip to content

8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 30, 2025

Please review this patch for the parity of Oracle's JDK-8185348.

Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation.

Before patch, slowjvmti test case from JDK-8185348:
16366ms

After patch:
3ms


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348228 needs maintainer approval

Issue

  • JDK-8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/656/head:pull/656
$ git checkout pull/656

Update a local copy of the PR:
$ git checkout pull/656
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/656/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 656

View PR using the GUI difftool:
$ git pr show -t 656

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/656.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented May 30, 2025

⚠️ @zhengyu123 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants