Skip to content

feat: make theme color configurable #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Conversation

openscript
Copy link
Member

No description provided.

@openscript openscript linked an issue Apr 3, 2025 that may be closed by this pull request
6 tasks
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: 0e5e420

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 16.99%. Comparing base (dff0f77) to head (0e5e420).

Files with missing lines Patch % Lines
apps/frontend/src/main.tsx 0.00% 5 Missing ⚠️
apps/frontend/src/routes/__root.tsx 0.00% 5 Missing ⚠️
apps/frontend/src/sections/HeroSection.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   16.95%   16.99%   +0.04%     
==========================================
  Files         131      131              
  Lines        3963     3971       +8     
  Branches      132      126       -6     
==========================================
+ Hits          672      675       +3     
- Misses       3232     3237       +5     
  Partials       59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openscript openscript requested a review from Copilot April 7, 2025 10:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 20 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • .devcontainer/devcontainer.json: Language not supported
  • apps/frontend/.docker/entrypoint.sh: Language not supported
  • apps/frontend/.env: Language not supported
  • apps/frontend/Dockerfile: Language not supported
  • apps/frontend/index.html: Language not supported
  • libs/ui/src/components/Hero.module.css: Language not supported
Comments suppressed due to low confidence (3)

apps/frontend/src/configuration.ts:3

  • The updated check filters out environment variables starting with '$'. Verify that this change is intentional and does not inadvertently ignore valid environment values.
if (window.env[key]?.startsWith("$") ) return;

libs/ui/src/theme/ThemeProvider.tsx:41

  • Ensure that the change from 'theme' to 'defaultTheme' is consistently propagated across all consumers to avoid unexpected theming behavior.
<MantineProvider theme={defaultTheme} {...args}>

apps/frontend/src/main.tsx:27

  • Verify that C.env.themeColor is a valid key in the theme palette and that mergeThemeOverrides correctly applies the override to prevent potential theming issues.
const currentTheme = mergeThemeOverrides(defaultTheme, { primaryColor: C.env.themeColor });

@openscript openscript force-pushed the 204-configurable-theme branch from e90ee1b to de63f8a Compare April 8, 2025 08:41
Comment on lines 17 to 21
{logos.map((logo, index) => (
<a key={index} href={logo.href}>
<img src={logo.src} alt={logo.alt} height={logo.height || 50} />
</a>
))}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to pass the a components via the props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable theme
2 participants