-
Notifications
You must be signed in to change notification settings - Fork 1
feat: make theme color configurable #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 16.95% 16.99% +0.04%
==========================================
Files 131 131
Lines 3963 3971 +8
Branches 132 126 -6
==========================================
+ Hits 672 675 +3
- Misses 3232 3237 +5
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .devcontainer/devcontainer.json: Language not supported
- apps/frontend/.docker/entrypoint.sh: Language not supported
- apps/frontend/.env: Language not supported
- apps/frontend/Dockerfile: Language not supported
- apps/frontend/index.html: Language not supported
- libs/ui/src/components/Hero.module.css: Language not supported
Comments suppressed due to low confidence (3)
apps/frontend/src/configuration.ts:3
- The updated check filters out environment variables starting with '$'. Verify that this change is intentional and does not inadvertently ignore valid environment values.
if (window.env[key]?.startsWith("$") ) return;
libs/ui/src/theme/ThemeProvider.tsx:41
- Ensure that the change from 'theme' to 'defaultTheme' is consistently propagated across all consumers to avoid unexpected theming behavior.
<MantineProvider theme={defaultTheme} {...args}>
apps/frontend/src/main.tsx:27
- Verify that C.env.themeColor is a valid key in the theme palette and that mergeThemeOverrides correctly applies the override to prevent potential theming issues.
const currentTheme = mergeThemeOverrides(defaultTheme, { primaryColor: C.env.themeColor });
e90ee1b
to
de63f8a
Compare
…tion and move the footer logo asset to public
{logos.map((logo, index) => ( | ||
<a key={index} href={logo.href}> | ||
<img src={logo.src} alt={logo.alt} height={logo.height || 50} /> | ||
</a> | ||
))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be possible to pass the a
components via the props.
No description provided.