Skip to content

SRVKS-1222: Add section with Kourier and Istio diagrams #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ochromy
Copy link

@ochromy ochromy commented Apr 8, 2025

Issue link:

Motivation:

  • We need to include the ingress diagrams in the downstream Serverless docs.
    BUT
  • The professional diagrams are not ready yet.
    THEREFORE
  • We want to add the diagrams (along with the necessary context) to the developer preview docs and link to them in the downstream docs until the professional diagrams are available.

Contents:

@openshift-ci-robot
Copy link

@ochromy: This pull request references SRVKS-1222 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.19.0" version, but no target version was set.

In response to this:

Issue link:

Motivation:

  • We need to include the ingress diagrams in the downstream Serverless docs.
    BUT
  • The professional diagrams are not ready yet.
    THEREFORE
  • We want to add the diagrams (along with the necessary context) to the developer preview docs and link to them in the downstream docs until the professional diagrams are available.

Contents:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ochromy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit f6e9d83
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/67f5111b545e6b0008b0c19e
😎 Deploy Preview https://deploy-preview-121--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Add diagrams in PNG

Add figure names to diagrams

Add assembly to NAV

NAV name correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants