Skip to content

[release-v1.17] If no subscriber uri is present we return 404, instead of 400 #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-v1.17
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1243

/assign matzew

…eans the request from the client itself would have had isssues

Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

openshift-ci bot commented Apr 11, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-test-reconciler 632d110 link true /test 417-test-reconciler

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Apr 14, 2025
Copy link

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-apiserver-receive-adapter-117-on-pull-request

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-apiserver-receive-adapter-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-controller-117-on-pull-request

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-controller-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-migrate-117-on-pull-request

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-migrate-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-schema-117-on-pull-request

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-schema-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-test-event-sender-117-on-pull-request

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/test kn-eventing-test-eventshub-117-on-pull-request

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-test-event-sender-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Apr 15, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.17-417-images
pull-ci-openshift-knative-eventing-release-v1.17-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.17-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.17-417-test-reconciler

In response to this:

/test kn-eventing-test-eventshub-117-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants