Skip to content

Run make prow-config after prow configs get created #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@openshift-ci openshift-ci bot requested a review from skonto April 23, 2025 12:57
@creydr
Copy link
Member Author

creydr commented Apr 23, 2025

@rudyredhat1 @Kaustubh-pande could you PTAL?

@rudyredhat1
Copy link
Collaborator

/lgtm

@rudyredhat1
Copy link
Collaborator

/approve

@rudyredhat1
Copy link
Collaborator

i think tide is waiting for the go unit tests to pass, can we retest and check that or is it a flake? @creydr

@rudyredhat1
Copy link
Collaborator

/retest Go unit tests (pull_request)

Copy link

openshift-ci bot commented Apr 23, 2025

@rudyredhat1: No presubmit jobs available for openshift-knative/hack@main

In response to this:

/retest Go unit tests (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cardil
Copy link
Member

cardil commented Apr 23, 2025

@creydr run: make generate-ci-action and commit

@openshift-ci openshift-ci bot removed the lgtm label Apr 23, 2025
@dsimansk
Copy link
Contributor

/approve
/lgtm

Copy link

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, creydr, dsimansk, rudyredhat1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09ead05 into openshift-knative:main Apr 23, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants