feat: support PipelineRun running status reporting with Kueue

[zakisk]

This adds support running status of the PipelineRun when PipelineRuns are managed by Kueue.

https://issues.redhat.com/browse/SRVKP-7738

Changes

Submitter Checklist

• 📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).

• ♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.

• ✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).

• 📖 Document any user-facing features or changes in behavior.

• 🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.

• 🎁 If feasible, add an end-to-end test. See README for details.

• 🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).

• If adding a provider feature, fill in the following details:

  • GitHub App
  • GitHub Webhook
  • Gitea/Forgejo
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center

  (update the provider documentation accordingly)

[pramodbindal]

PR looks good to me.
When can expect this PR available in nightly ?

[zakisk]

PR looks good to me. When can expect this PR available in nightly ?

@pramodbindal after merge, it will be in nightly

[pramodbindal]

PR looks good to me. When can expect this PR available in nightly ?

@pramodbindal after merge, it will be in nightly

:-) My question was that only. when are you planning to merge

[zakisk]

waiting for reviewers 🙂

[chmouel]

🤖 AI Review provided by openrouter:deepseek/deepseek-r1:free:

The analysis of the provided code changes reveals a few areas that need attention:

Bugs and Issues:

1. Test Does Not Verify Labels:
   • Location: pipelineascode_test.go
   • Issue: The tests check the queued state in annotations but do not verify the corresponding labels. The code adds both annotations and labels, so the tests should validate both to ensure correctness.
   • Fix: Update tests to check both annotations and labels. For example:

     stateAnnotation, ok := pr.GetAnnotations()[keys.State]
     assert.Assert(t, ok, "State annotation missing")
     assert.Equal(t, stateAnnotation, kubeinteraction.StateQueued)
     stateLabel, ok := pr.GetLabels()[keys.State]
     assert.Assert(t, ok, "State label missing")
     assert.Equal(t, stateLabel, kubeinteraction.StateQueued)

Spelling Mistake:

• Commit Message Typo:
  • Issue: The commit message has "Github" instead of the correct "GitHub".
  • Fix: Amend the commit message to use "GitHub".

Code Improvements:

1. Test Coverage for Merge Patch:
   • Location: pipelineascode_test.go (TestGetMergePatch)
   • Improvement: The test for getMergePatch doesn't check label patching. Add a case to verify both annotations and labels are patched.

     func TestGetMergePatchWithLabels(t *testing.T) {
         ann := map[string]string{keys.State: kubeinteraction.StateQueued}
         labels := map[string]string{keys.State: kubeinteraction.StateQueued}
         result := getMergePatch(ann, labels)
         m, ok := result["metadata"].(map[string]any)
         assert.Assert(t, ok)
         a, ok := m["annotations"].(map[string]string)
         assert.Assert(t, ok)
         assert.Equal(t, a[keys.State], kubeinteraction.StateQueued)
         l, ok := m["labels"].(map[string]string)
         assert.Assert(t, ok)
         assert.Equal(t, l[keys.State], kubeinteraction.StateQueued)
     }

Code Style and Clarity:

• Function Naming: The function getMergePatch is functional, but a more descriptive name like createMetadataPatch could enhance readability.
• Comments: Clarify that the reconciler (watcher) uses the state annotations and labels to track PipelineRun status for reporting to the Git provider.

Summary: The code effectively adds queued state reporting but requires test adjustments to ensure labels are verified, a minor typo fix, and enhanced test coverage for patches.

[chmouel]

I have tested it and it worked very nicely

https://streamable.com/3wrn4a

Can you provide some documentation to point that PAC is compatible with kueue and that it can provide an alternative to our concurrency system.. You don't need to go over the whole setup process...

[chmouel]

@pramodbindal we don't merge our own PR in PAC, unless we have approved reviewers, and this should be the standard for every openshift-pipelines projects

[zakisk]

Can you provide some documentation to point that PAC is compatible with kueue and that it can provide an alternative to our concurrency system.. You don't need to go over the whole setup process...

@chmouel okay, will do. thanks!

[zakisk]

@chmouel PTAL.