fix(gitlab): trigger PipelineRun only on label change #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuneetPunamiya
force-pushed
the
fix-pipeline-of-mr-retriggered-when-desc-changed
branch
from
03c7ddf to
6a0a3cd
Compare
PuneetPunamiya
changed the title
zakisk
reviewed
Jun 12, 2025
PuneetPunamiya
force-pushed
the
fix-pipeline-of-mr-retriggered-when-desc-changed
branch
from
6a0a3cd to
b1d8cb1
Compare
zakisk
force-pushed
the
fix-pipeline-of-mr-retriggered-when-desc-changed
branch
from
b1d8cb1 to
e0fe4ed
Compare
zakisk
reviewed
Jun 16, 2025
Before this patch pipeline was triggered on any merge request update, regardless of what changed such as title, description or assigne changes With the current change, pipeline will be triggered only when labels are added or removed Signed-off-by: PuneetPunamiya <[email protected]>
PuneetPunamiya
force-pushed
the
fix-pipeline-of-mr-retriggered-when-desc-changed
branch
from
e0fe4ed to
f8866d3
Compare
zakisk
reviewed
Jun 19, 2025
Comment on lines
+666
to
+689
| // Send another Push to make an update and make sure we react to it | ||
| entries, err = payload.GetEntries(map[string]string{ | ||
| "hello-world.yaml": "testdata/pipelinerun.yaml", | ||
| }, targetNS, projectinfo.DefaultBranch, | ||
| triggertype.PullRequest.String(), map[string]string{}) | ||
| assert.NilError(t, err) | ||
| scmOpts.BaseRefName = targetRefName | ||
| _ = scm.PushFilesToRefGit(t, scmOpts, entries) | ||
|
|
||
| sopt := twait.SuccessOpt{ | ||
| Title: commitTitle, | ||
| OnEvent: "Merge Request", | ||
| TargetNS: targetNS, | ||
| NumberofPRMatch: 4, | ||
| SHA: "", | ||
| } | ||
| twait.Succeeded(ctx, t, runcnx, opts, sopt) | ||
| prsNew, err := runcnx.Clients.Tekton.TektonV1().PipelineRuns(targetNS).List(ctx, metav1.ListOptions{}) | ||
| assert.NilError(t, err) | ||
| assert.Assert(t, len(prsNew.Items) == 4) | ||
|
|
||
| for i := 0; i < len(prsNew.Items); i++ { | ||
| assert.Equal(t, "Merge Request", prsNew.Items[i].Annotations[keys.EventType]) | ||
| } |
There was a problem hiding this comment.
I think don't need to re-trigger two pipelineruns again, pipelineruns created on merge request open are sufficient.
zakisk
reviewed
Jun 19, 2025
Comment on lines
+691
to
+695
| runcnx.Clients.Log.Infof("Changing Title on MergeRequest %s/-/merge_requests/%d", projectinfo.WebURL, mrID) | ||
| _, _, err = glprovider.Client().MergeRequests.UpdateMergeRequest(opts.ProjectID, mrID, &clientGitlab.UpdateMergeRequestOptions{ | ||
| Title: clientGitlab.Ptr("test"), | ||
| }) | ||
| assert.NilError(t, err) |
There was a problem hiding this comment.
after updating title, if you immediately check whether PipelineRuns are created or not, it will always be 4 because it takes sometime to create PipelineRun and the test is exiting right after updating the title so I think you should wait for sometime to confirm that no PipelineRun has been created. you can do something similar below:
zakisk
reviewed
Jun 19, 2025
| changes.Assignees.Previous == nil && changes.Assignees.Current == nil && | ||
| changes.Reviewers.Previous == nil && changes.Reviewers.Current == nil && | ||
| changes.Description.Previous == "" && changes.Description.Current == "" && | ||
| !changes.Draft.Previous && !changes.Draft.Current && |
There was a problem hiding this comment.
@chmouel we don't consider MR's draft state in GitLab, right? should we consider a "Merge Request Event" if an MR is converted to "ready" from draft??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch pipeline was triggered on any merge request update, regardless of what changed such as title, description or assigne changes
With the current change, pipeline will be triggered only when labels are added or removed
Fixes: https://issues.redhat.com/browse/SRVKP-7383
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)