Enhance hack/mirror-pr.sh with PR Management Features (Update, List/Close, Dry Run)
#2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a dry run mode to the `mirror-pr.sh` script. * Introduced the `-t` flag, which allowed users to preview commands prior to execution. * Implemented a `run` helper function to conditionally execute or log commands. * Wrapped all critical commands with the new dry run mechanism, including `git` and `gh` operations. * Updated the script's help message to document the new test mode option. * Enhanced script safety and debuggability by offering a non-destructive verification method. Signed-off-by: Chmouel Boudjnah <[email protected]>
- Added a new `-u` option to the `mirror-pr.sh` script. - Allowed users to select an existing mirrored pull request for direct updates. - Refactored command execution to remove `eval` for improved security. - Updated command line argument parsing for better maintainability. - Corrected help message wording and applied consistent quoting. Signed-off-by: Chmouel Boudjnah <[email protected]>
- Added a new `-c` command line option to `hack/mirror-pr.sh`. - Implemented functionality to list all mirrored pull requests in the repository. - Fetched the state of the original pull request for each mirrored PR. - Allowed interactive closing of mirrored PRs if their original counterparts were merged or closed. - Corrected a formatting issue in the `fzf` interactive selection. Signed-off-by: Chmouel Boudjnah <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the mirror-pr.sh script by adding new PR management features for mirrored pull requests.
- Added dry run (-t), update (-u), and list/close (-c) modes for safer and more flexible PR handling.
- Introduced an interactive prompt to close mirrored PRs when the corresponding original PR is merged or closed.
- Refactored command executions using the run() helper to support test mode log messages.
chmouel
force-pushed
the
mirror-script-more-features
branch
2 times, most recently
from
97c98de to
e8ab27a
Compare
* Updated the Gitlint invocation method within the Tekton pipeline script. * Changed the commit linting check to collect all non-compliant commit hashes. * Modified the step to output a list of every commit that failed the linting check before exiting. * Provided clearer feedback to developers by identifying all commits needing correction. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
mirror-script-more-features
branch
from
e8ab27a to
1e50579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
hack/mirror-pr.shscript, improving the workflow for managing mirrored pull requestsused for testing external contributions.
Key features and improvements include:
-c): Added a new option (-c) to list all mirrored pull requests in the repository. The scriptnow fetches the state of the original PR and interactively prompts the user to close the mirrored PR if the original has been merged or closed.
Updating Existing Mirrored PRs (
-u): Introduced an update mode (-u) that allows selecting an existing mirrored pull request viafzfandupdating it with the latest changes from the original contributor's branch.
Dry Run Mode (
-t): Added a dry run option (-t) to the script, enabling users to preview the commands that would be executed without makingany actual changes. This enhances safety and debuggability.
fix: Improve Tekton gitlint step to list all failing commits