Hotfix dev env #372
Hotfix dev env #372
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaphaelBut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
RaphaelBut
force-pushed
the
hotfix-dev-env
branch
from
266c9ca to
fd44b4c
Compare
openshift-merge-robot
added
the
needs-rebase
|
/retest |
This comes out of a need to run backplane-api locally, but its unable to get aws access. Also, part of the bigger picture of only initializing required integrations.
RaphaelBut
force-pushed
the
hotfix-dev-env
branch
from
7479d85 to
b707bac
Compare
openshift-merge-robot
removed
the
needs-rebase
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 33.69% 33.45% -0.24%
==========================================
Files 25 25
Lines 1843 1856 +13
==========================================
Hits 621 621
- Misses 1174 1187 +13
Partials 48 48
🚀 New features to boost your workflow:
|
|
@RaphaelBut: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| updateMetrics(alertInvestigation.Name(), &result) | ||
| return err | ||
| var customerAwsClient *aws.SdkClient | ||
| if alertInvestigation.RequiresAwsClient() { |
There was a problem hiding this comment.
Question: how would we test aws access + kube-api access short term?
This is an interesting side effect of running the local backplane-api.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Improve dev environment setup and add utility to run backplane locally
Only require aws client for investigations that need it.
This comes out of a need to run backplane-api locally, but its unable to get aws access.
Its also part of the bigger picture of only initializing required integrations.