Skip to content

OSD-29208 - Remove CAD template file generation #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MateSaary
Copy link
Member

This PR deprecates CAD's template file generation, in favour of allowing for manual direct editing of the template.yaml file.
The PR also removes PD secrets from the template as it is understood that these are redundant, as they are generated by app-interface with the vault provider resource.

Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MateSaary
Once this PR has been reviewed and has the lgtm label, please assign rafael-azevedo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.80%. Comparing base (405e5ad) to head (8a9fc12).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   31.80%   31.80%           
=======================================
  Files          28       28           
  Lines        1984     1984           
=======================================
  Hits          631      631           
  Misses       1305     1305           
  Partials       48       48           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MateSaary MateSaary force-pushed the OSD-29208-remove-template-generation branch 2 times, most recently from 6f55bc3 to f13e709 Compare April 23, 2025 13:06
@MateSaary MateSaary force-pushed the OSD-29208-remove-template-generation branch from f13e709 to 8a9fc12 Compare April 23, 2025 13:19
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

@MateSaary: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants