OCPBUGS-43792: Follow-on fix. Add new "plugins-order" flag to bridge cli args #14981

TheRealJon · 2025-04-18T19:32:39Z

Since "plugins" is an unordered map, we need a new way to enforce plugin resolution order from console operator config to the frontend.

openshift-ci-robot · 2025-04-18T19:32:44Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-43792, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since "plugins" is an unordered map, we need a new way to enforce plugin resolution order from console operator config to the frontend.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-18T19:33:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/OWNERS~~ [TheRealJon]
~~pkg/OWNERS~~ [TheRealJon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TheRealJon · 2025-04-18T19:35:31Z

/hold
wait for openshift/console-operator#980

TheRealJon · 2025-04-18T19:37:34Z

/jira refresh

openshift-ci-robot · 2025-04-18T19:37:42Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-43792, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

spadgett

I'm fine with this approach. It's good to avoid breaking plugins that use the template by changing existing CLI args. Thanks, Jon.

cmd/bridge/main.go

TheRealJon · 2025-04-21T14:05:55Z

/retest

TheRealJon · 2025-05-02T14:44:54Z

/jira refresh

openshift-ci-robot · 2025-05-02T14:44:58Z

@TheRealJon: This pull request references Jira Issue OCPBUGS-43792, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-05-02T14:46:43Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-05-02T14:46:45Z

@TheRealJon: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TheRealJon · 2025-05-02T15:33:05Z

/retest

…cli args since "plugins" is an undordered map. We need a way to persist plugin order from console operator config to the frontend server flag.

openshift-ci · 2025-05-15T18:32:35Z

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	`1d02a27`	link	true	`/test verify-deps`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

TheRealJon · 2025-05-16T14:18:43Z

/retest

TheRealJon · 2025-05-16T14:18:56Z

/hold cancel

jhadvig · 2025-05-20T10:18:28Z

cmd/bridge/main.go

@@ -235,6 +236,20 @@ func main() {
 		}
 	}

+	pluginsOrder := []string{}
+	if *fPluginsOrder != "" {
+		for _, str := range strings.Split(*fPluginsOrder, ",") {


hmm wondering if we should sort them here? Or it should be done on the operator side...

Suggested change

for _, str := range strings.Split(*fPluginsOrder, ",") {

for _, str := range slices.Sort(strings.Split(*fPluginsOrder, ",")) {

jhadvig · 2025-05-20T10:32:20Z

cmd/bridge/main.go

@@ -235,6 +236,20 @@ func main() {
 		}
 	}

+	pluginsOrder := []string{}


this section feels like it should be a function on its own.
func orderPlugins()

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 18, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 18, 2025

openshift-ci bot requested review from jhadvig and rhamilto April 18, 2025 19:32

openshift-ci bot added the component/backend Related to backend label Apr 18, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 18, 2025

openshift-ci bot requested a review from yapei April 18, 2025 19:37

spadgett reviewed Apr 18, 2025

View reviewed changes

cmd/bridge/main.go Outdated Show resolved Hide resolved

TheRealJon force-pushed the OCPBUGS-43792 branch from f4b0f26 to da8ff10 Compare April 21, 2025 17:47

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2025

TheRealJon force-pushed the OCPBUGS-43792 branch from da8ff10 to 1d02a27 Compare May 5, 2025 15:36

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2025

OCPBUGS-43792: Follow-on fix. Add new "plugins-order" flag to bridge …

73ba098

…cli args since "plugins" is an undordered map. We need a way to persist plugin order from console operator config to the frontend server flag.

TheRealJon force-pushed the OCPBUGS-43792 branch from 1d02a27 to 73ba098 Compare May 15, 2025 15:04

openshift-ci-robot mentioned this pull request May 15, 2025

OCPBUGS-43792: Add plugins order to console config openshift/console-operator#980

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025

jhadvig reviewed May 20, 2025

View reviewed changes

	for _, str := range strings.Split(*fPluginsOrder, ",") {
	for _, str := range slices.Sort(strings.Split(*fPluginsOrder, ",")) {

OCPBUGS-43792: Follow-on fix. Add new "plugins-order" flag to bridge cli args #14981

Are you sure you want to change the base?

OCPBUGS-43792: Follow-on fix. Add new "plugins-order" flag to bridge cli args #14981

Uh oh!

Conversation

TheRealJon commented Apr 18, 2025

Uh oh!

openshift-ci-robot commented Apr 18, 2025

Uh oh!

openshift-ci bot commented Apr 18, 2025

Uh oh!

TheRealJon commented Apr 18, 2025

Uh oh!

TheRealJon commented Apr 18, 2025

Uh oh!

openshift-ci-robot commented Apr 18, 2025

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheRealJon commented Apr 21, 2025

Uh oh!

TheRealJon commented May 2, 2025

Uh oh!

openshift-ci-robot commented May 2, 2025

Uh oh!

TheRealJon commented May 2, 2025

Uh oh!

openshift-cherrypick-robot commented May 2, 2025

Uh oh!

TheRealJon commented May 2, 2025

Uh oh!

openshift-ci bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheRealJon commented May 16, 2025

Uh oh!

TheRealJon commented May 16, 2025

Uh oh!

jhadvig May 20, 2025

Choose a reason for hiding this comment

Uh oh!

jhadvig May 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented May 15, 2025 •

edited

Loading