Skip to content

[Builds-1.2] Added Pipeline as reference and updated images #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

psrvere
Copy link

@psrvere psrvere commented Apr 11, 2025

Changes

  • Updated ubi and go-toolset images
  • Update pipeline as reference

@openshift-ci openshift-ci bot requested review from otaviof and sayan-biswas April 11, 2025 10:03
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 11, 2025
Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

Hi @psrvere. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 11, 2025
@sayan-biswas
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2025
@psrvere
Copy link
Author

psrvere commented Apr 14, 2025

/retest

@psrvere
Copy link
Author

psrvere commented Apr 14, 2025

/test conforma-openshift-builds-1-2 / openshift-builds-shared-resource-1-2

@ayushsatyam146
Copy link
Contributor

/retest

Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@psrvere: No presubmit jobs available for openshift/[email protected]

In response to this:

/test conforma-openshift-builds-1-2 / openshift-builds-shared-resource-1-2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@psrvere
Copy link
Author

psrvere commented Apr 15, 2025

/retest

1 similar comment
@ayushsatyam146
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@sayan-biswas
Copy link
Contributor

/ok-to-test

@psrvere
Copy link
Author

psrvere commented Apr 15, 2025

/test openshift-builds-shared-resource-webhook-on-pull-request

Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@psrvere: No presubmit jobs available for openshift/[email protected]

In response to this:

/test openshift-builds-shared-resource-webhook-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ayushsatyam146
Copy link
Contributor

/retest

@ayushsatyam146
Copy link
Contributor

/ok-to-test

Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psrvere can you please make it only two commits and also change the PR title accordingly.

  1. images updates
  2. pipeline updates

@avinal
Copy link
Member

avinal commented Apr 15, 2025

It is preferable to do only one task in a PR. It is fine for this one.

@psrvere psrvere changed the title [Builds-1.2] Updated ubi and go-toolset images [Builds-1.2] Added Pipeline as reference and updated images Apr 15, 2025
@ayushsatyam146
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, psrvere, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas sayan-biswas merged commit 84f7afc into openshift:builds-1.2 Apr 15, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants