Skip to content

use our _kubectl wrapper within deploy-nfd and deploy-nvidia.sh #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

rphillips
Copy link
Contributor

@rphillips rphillips commented Apr 10, 2025

_kubectl injects whether we choose oc or kubectl from the environment.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2025
@openshift-ci openshift-ci bot requested review from kannon92 and mamy-CS April 10, 2025 21:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@mrunalp
Copy link
Member

mrunalp commented Apr 10, 2025

Can we add a comment for the rationale?

_kubectl will use the environment variable override if set.
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
Copy link

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 10, 2025

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor Author

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-daemonset"

Copy link

openshift-ci bot commented Apr 10, 2025

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-daemonset

In response to this:

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-daemonset"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 60b55f4 into openshift:main Apr 10, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants