Skip to content

Ability to use token in noop auth (if needed) #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Mar 10, 2025

Description

Ability to use token in noop auth (if needed). When this auth is set in config and user posts a query with token, noop is forwarding this token then instead of default value.

@onmete
Copy link
Contributor Author

onmete commented Mar 10, 2025

@tisnik WDYT?
I have this need to post the token to my local instance when testing the tools. I'm fine if there is another workaround.

@openshift-ci openshift-ci bot requested review from bparees and joshuawilson March 10, 2025 12:32
@onmete
Copy link
Contributor Author

onmete commented Mar 11, 2025

/test 4.17-e2e-ols-cluster

@raptorsun
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/retest

@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/approve

Copy link

openshift-ci bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2025
@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/override "Red Hat Konflux / lightspeed-service-on-pull-request"
/override "Red Hat Konflux / integration-tests / lightspeed-service"
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

Copy link

openshift-ci bot commented Mar 31, 2025

@tisnik: Overrode contexts on behalf of tisnik: Red Hat Konflux / integration-tests / lightspeed-service, Red Hat Konflux / lightspeed-service-on-pull-request, Red Hat Konflux / ols-enterprise-contract / lightspeed-service

In response to this:

/override "Red Hat Konflux / lightspeed-service-on-pull-request"
/override "Red Hat Konflux / integration-tests / lightspeed-service"
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/test 4.17-e2e-ols-cluster

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD abf4182 and 2 for PR HEAD 9b2624b in total

@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/retest

@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/test 4.17-e2e-ols-cluster

@tisnik
Copy link
Contributor

tisnik commented Mar 31, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0bd596f and 1 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0bd596f and 2 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2ced467 and 2 for PR HEAD 9b2624b in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2ced467 and 2 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2ced467 and 2 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2ced467 and 2 for PR HEAD 9b2624b in total

@tisnik
Copy link
Contributor

tisnik commented Apr 1, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b2b018b and 1 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b2b018b and 2 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 031e93e and 1 for PR HEAD 9b2624b in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 73e0d1b and 2 for PR HEAD 9b2624b in total

@onmete onmete force-pushed the use-token-in-noop branch from 9b2624b to 12a2367 Compare April 2, 2025 12:51
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
Copy link

openshift-ci bot commented Apr 2, 2025

New changes are detected. LGTM label has been removed.

@onmete
Copy link
Contributor Author

onmete commented Apr 15, 2025

/retest

1 similar comment
@onmete
Copy link
Contributor Author

onmete commented Apr 15, 2025

/retest

Copy link

openshift-ci bot commented Apr 15, 2025

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@onmete
Copy link
Contributor Author

onmete commented Apr 15, 2025

closing in favor of #2441

@onmete onmete closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants