RHDEVDOCS-6267 #92126
RHDEVDOCS-6267 #92126
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Tue Apr 22 19:55:31 - Prow CI generated the docs preview: https://92126--ocpdocs-pr.netlify.app/openshift-builds/latest/configuring/configuring-build-runs.html |
|
I apologize for submitting this so late |
|
please review and approve this PR if everything is ok. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
lahinson
added
peer-review-in-progress
There was a problem hiding this comment.
Nice work! I provided some suggestions based on the OCP docs guidelines for your consideration. I wasn't able to use the generated preview to confirm that the table formatting was correct, so you might want to double check that locally. Before you submit this for merge review, be sure to squash your commits down to 1. Thanks!
lahinson
added
peer-review-done
added 1.2.1 RN file Remove prerequisite from builds fixed example file moved callout replaced `shp` CLI download link RHDEVDOCS-6267 RHDEVDOCS-6267 fixed example file moved callout replaced `shp` CLI download link RHDEVDOCS-6267 RHDEVDOCS-6267 Update modules/ob-configuring-pods-in-build-run.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-build-runs.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-build-runs.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-openshift-builds.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-build-runs.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-openshift-builds.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update modules/ob-configuring-pods-in-build-run.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update configuring/configuring-openshift-builds.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update modules/ob-configuring-pods-in-build-run.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update modules/ob-configuring-pods-in-build.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update modules/ob-configuring-pods-in-build.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com> Update modules/ob-configuring-pods-in-build.adoc Co-authored-by: Laura Hinson <lahinson@redhat.com>
deerskindoll
force-pushed
the
RHDEVDOCS-6267
branch
from
896e463 to
de642b5
Compare
|
@deerskindoll: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
reference modules for optional pod configuration fields in
BuildandBuildRunCRsVersion(s):
build-docs-main
build-docs-1.4
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6267
Link to docs preview:
QE review:
no QE available
Additional information: