Skip to content

OSDOCS#14285: Removing unsupported KDO versions #92134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

OSDOCS#14285: Removing unsupported KDO versions #92134

merged 1 commit into from
May 13, 2025
+12 −82

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Apr 14, 2025 •
edited
Loading

Sorry, something went wrong.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2025
@bergerhoffer bergerhoffer added this to the Planned for 4.19 GA milestone Apr 14, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 14, 2025 •
edited
Loading

🤖 Tue May 13 12:58:07 - Prow CI generated the docs preview:

https://92134--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/descheduler/index.html
https://92134--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/descheduler/nodes-descheduler-configuring.html
https://92134--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/descheduler/nodes-descheduler-release-notes.html
https://92134--ocpdocs-pr.netlify.app/openshift-enterprise/latest/nodes/scheduling/descheduler/nodes-descheduler-uninstalling.html

@bergerhoffer
Copy link
Contributor Author

@ingvagabund @zhouying7780 Can you PTAL?

This is just adding the note saying that there won't be a descheduler operator version right at GA (until the one releases post-GA). And removes release notes for versions 5.1.0-5.1.2 (since they don't apply to 4.19).

Link to docs preview:

@bergerhoffer
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 16, 2025
@bergerhoffer
Copy link
Contributor Author

Holding off - there's a chance we might continue to support 5.1.z in 4.19. Need to sync with Ramona on 4.19 dates and then we'll decide.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 16, 2025
xenolinux
xenolinux reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 16, 2025
@zhouying7780
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@bergerhoffer
Copy link
Contributor Author

Confirmed that we do want to remove the 5.1.z versions for 4.19. Moving forward with this PR.

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@ingvagabund
Copy link
Member

LGTM

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer bergerhoffer merged commit 9a417a8 into openshift:main May 13, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #93293

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux

Assignees

@zhouying7780 zhouying7780

Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bergerhoffer @ocpdocs-previewbot @zhouying7780 @ingvagabund @openshift-cherrypick-robot @xenolinux @openshift-merge-robot