Skip to content

[SRVKS-1311] Link to the midstream architecture diagrams of Kourier and Istio #93338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

ochromy
Copy link

@ochromy ochromy commented May 14, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2025
@ocpdocs-previewbot
Copy link

🤖 Wed May 14 09:41:59 - Prow CI generated the docs preview:

https://93338--ocpdocs-pr.netlify.app/openshift-serverless/latest/knative-serving/kourier-and-istio-ingresses.html

Copy link

openshift-ci bot commented May 14, 2025

@ochromy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ochromy
Copy link
Author

ochromy commented May 26, 2025

/label serverless
/label peer-review-needed

@openshift-ci openshift-ci bot added serverless Label for all Serverless PRs peer-review-needed Signifies that the peer review team needs to review this PR labels May 26, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 26, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 26, 2025
@ochromy
Copy link
Author

ochromy commented May 27, 2025

LGTM

Direct preview link: https://93338--ocpdocs-pr.netlify.app/openshift-serverless/latest/knative-serving/kourier-and-istio-ingresses.html#serverless-ingresses-traffic-configuration-and-routing_kourier-and-istio-ingresses

site is not working (page not found)

Hi @xenolinux,

The preview link here is working on my end.

If you're referring to the link included in the note, it's expected to return a 404 for now — the related PR hasn’t been merged into the upstream yet.

@ochromy
Copy link
Author

ochromy commented May 28, 2025

The related midstream PR had been merged.

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 28, 2025
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 28, 2025
@stevsmit stevsmit added this to the Continuous Release milestone May 28, 2025
@@ -36,6 +36,11 @@ See the "Integrating Service Mesh with OpenShift Serverless" section of {Serverl
[id="serverless-ingresses-traffic-configuration-and-routing_{context}"]
== Traffic configuration and routing

[NOTE]
====
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] site.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to hold up a merge review for this if (if it wasn't after hours I would've messaged you about it), but we should probably use "website" instead of "site." "Site" could have translation issues, and generally speaking IBMSG has an entry for website, though it doesn't explicitly say to use this over "site". https://www.ibm.com/docs/en/ibm-style?topic=word-usage#website

Suggested change
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] site.
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] website.

@stevsmit stevsmit merged commit 7d59618 into openshift:serverless-docs-main May 28, 2025
2 checks passed
@stevsmit
Copy link
Member

/cherry-pick serverless-docs-1.36

@openshift-cherrypick-robot

@stevsmit: new pull request created: #93837

In response to this:

/cherry-pick serverless-docs-1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants