-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[SRVKS-1311] Link to the midstream architecture diagrams of Kourier and Istio #93338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Wed May 14 09:41:59 - Prow CI generated the docs preview: |
@ochromy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label serverless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
site is not working (page not found)
Hi @xenolinux, The preview link here is working on my end. If you're referring to the link included in the note, it's expected to return a 404 for now — the related PR hasn’t been merged into the upstream yet. |
The related midstream PR had been merged. /label merge-review-needed |
@@ -36,6 +36,11 @@ See the "Integrating Service Mesh with OpenShift Serverless" section of {Serverl | |||
[id="serverless-ingresses-traffic-configuration-and-routing_{context}"] | |||
== Traffic configuration and routing | |||
|
|||
[NOTE] | |||
==== | |||
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to hold up a merge review for this if (if it wasn't after hours I would've messaged you about it), but we should probably use "website" instead of "site." "Site" could have translation issues, and generally speaking IBMSG has an entry for website, though it doesn't explicitly say to use this over "site". https://www.ibm.com/docs/en/ibm-style?topic=word-usage#website
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] site. | |
You can find the architecture diagrams for the Kourier and Istio ingresses on the link:https://openshift-knative.github.io/docs/docs/latest/serverless/serving/serving-kourier-istio-ingresses#serverless-ingresses-traffic-configuration-and-routing[Technology and Developer Preview Releases] website. |
/cherry-pick serverless-docs-1.36 |
@stevsmit: new pull request created: #93837 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
serverless-docs-1.36
Issue:
Link to docs preview:
QE review:
Additional information:
A subtask of SRVKS-1222