Skip to content

MCO-1634: Enhance SNO stability for MachineConfigNode tests #29667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

isabella-janssen
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025

@isabella-janssen: This pull request references MCO-1634 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2025
Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

/test e2e-aws-ovn-single-node-techpreview-serial

Copy link
Contributor

openshift-ci bot commented Apr 9, 2025

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-techpreview-serial 86cdfa7 link false /test e2e-aws-ovn-single-node-techpreview-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xueqzhan and others added 19 commits April 9, 2025 20:44
…ests

Value was previously hardcoded. Can be replaced now since openshift/api
has been bumped and has the `configv1.ClusterVersionCapabilityOperatorLifecycleManagerV1`
constant.

Signed-off-by: Anik Bhattacharjee <[email protected]>
When IPsec tests configuring certificates into libreswan nss db for
north south traffic via a machine config, it's rebooting worker nodes
by default which still makes one of the following monitor test to fail.

4 unexpected clusteroperator state transitions during e2e test run.  These did not match any known exceptions, so they cause this test-case to fail:

Jan 15 19:44:18.575 E clusteroperator/kube-storage-version-migrator condition/Available reason/KubeStorageVersionMigrator_Deploying status/False KubeStorageVersionMigratorAvailable: Waiting for Deployment
Jan 15 19:44:18.575 - 5s    E clusteroperator/kube-storage-version-migrator condition/Available reason/KubeStorageVersionMigrator_Deploying status/False KubeStorageVersionMigratorAvailable: Waiting for Deployment
Jan 15 20:06:29.820 E clusteroperator/kube-storage-version-migrator condition/Available reason/KubeStorageVersionMigrator_Deploying status/False KubeStorageVersionMigratorAvailable: Waiting for Deployment
Jan 15 20:06:29.820 - 1s    E clusteroperator/kube-storage-version-migrator condition/Available reason/KubeStorageVersionMigrator_Deploying status/False KubeStorageVersionMigratorAvailable: Waiting for Deployment

2 unwelcome but acceptable clusteroperator state transitions during e2e test run.  These should not happen, but because they are tied to exceptions, the fact that they did happen is not sufficient to cause this test-case to fail:

Jan 15 19:44:24.518 W clusteroperator/kube-storage-version-migrator condition/Available reason/AsExpected status/True All is well (exception: Available=True is the happy case)
Jan 15 20:06:31.725 W clusteroperator/kube-storage-version-migrator condition/Available reason/AsExpected status/True All is well (exception: Available=True is the happy case)

Actually it is not required to reboot the nodes just for configuring
certs on the nss db. Hence adding nod edisruption machine configuration
policy so that nodes are not rebooted while deploying certificates on the
worker nodes.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
When IPsec mode are changed across tests within IPsec test suite,
it causes reboot of ovnkube-node daemonset pods, It's expected
workload traffic would fail temporarily until pods are settle down
after IPsec is properly configured in every node's OVN and OvS across
the cluster. So we should not test ipsec mode change in the ipsec
test suite and instead for every ipsec mode, there should be one CI lane,
then in the test corresponding configuration and traffic must be tested.

So this commit removes everything related to IPsec mode changes and having
a single test which can be run from Full and External IPsec mode CI lanes.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
… to docs.redhat.com after docs migration

docs.openshift.com got moved to docs.redhat.com and our egress firewall/egressnetworkpolicy tests were
using that fqdn to curl and test for egress firewall functionality. With the DNS name no longer resolving,
these tests need to be updated to the docs.redhat.com server instead.
This is the binding which we will use on 4.18.

In later releases we expect passt to replace it, but, its shortcomings
(unable to preserve TCP connections during live migration) make it a bad
candidate for the binding of the primary network attachment.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
The Unmarshal function uses strict decoding by default. This means that the
target object must define all fields present in the CBOR data. Otherwise,
it returns an unknown field error. This patch fixes that by using a
intermediary map[string]any.
The timelines-chart seems to have changed at this unpkg location, if you
load that in a browser and search for the TimelinesChart object we use,
it's no longer there, though it does load some js.

The github repo for the actual project
https://github.com/vasturiano/timelines-chart
recommends this new url and I've confirmed this works by downloading an
html intervals file and editing it.
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member Author

/close

@openshift-ci openshift-ci bot closed this Apr 14, 2025
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@isabella-janssen: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.