misc fixes to make the operator runnable #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpratt
force-pushed
the
working-operator
branch
from
58736a8 to
f81d2f1
Compare
|
/test lint |
|
/retest |
1 similar comment
|
/retest |
jbpratt
force-pushed
the
working-operator
branch
from
f81d2f1 to
b42e4e3
Compare
so that we can reconcile Example CRs Signed-off-by: bpratt <[email protected]>
Signed-off-by: bpratt <[email protected]>
Signed-off-by: bpratt <[email protected]>
Signed-off-by: bpratt <[email protected]>
Signed-off-by: bpratt <[email protected]>
This reverts commit 9344ea5.
Signed-off-by: bpratt <[email protected]>
these are all defaulted in the pipeline Signed-off-by: bpratt <[email protected]>
This reverts commit a526b91.
Signed-off-by: bpratt <[email protected]>
nonroot is not a user in these images, set up the user Signed-off-by: bpratt <[email protected]>
jbpratt
force-pushed
the
working-operator
branch
from
b42e4e3 to
6a1d639
Compare
mv controllers -> internal mv main.go -> cmd rename imports Signed-off-by: bpratt <[email protected]>
Signed-off-by: bpratt <[email protected]>
this needs to build ./cmd instead need to figure out a patch that can be sent to boilerplate Signed-off-by: bpratt <[email protected]>
|
@jbpratt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.