Skip to content

Update path for splunk-forwarder-images dockerfile #63828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

wshearn
Copy link
Contributor

@wshearn wshearn commented Apr 14, 2025

Moving the SFI dockerfile into build directory instead of a bespoke path.

PR in SFI with the change; openshift/splunk-forwarder-images#67

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@openshift-ci openshift-ci bot requested review from afreiberger and boranx April 14, 2025 20:36
@ritmun
Copy link
Contributor

ritmun commented Apr 14, 2025

If you'd like to rehearse either one of these jobs #63828 (comment)

you can comment /pj-rehearse <job name> eg /pj-rehearse pull-ci-openshift-splunk-forwarder-images-master-images

otherwise you can skip rehearse with /pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@wshearn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-splunk-forwarder-images-master-images openshift/splunk-forwarder-images presubmit Ci-operator config changed
pull-ci-openshift-splunk-forwarder-images-master-vuln-check-forwarder openshift/splunk-forwarder-images presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dem4gus
Copy link

dem4gus commented Apr 14, 2025

/label tide/merge-method-squash
/lgtm

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 14, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dem4gus, wshearn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

@wshearn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wshearn
Copy link
Contributor Author

wshearn commented Apr 14, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@wshearn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 85f1671 into openshift:master Apr 14, 2025
13 checks passed
mehabhalodiya pushed a commit to mehabhalodiya/release that referenced this pull request Apr 15, 2025
* Update path for splunk forwarder images dockerfile

* Use build/Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants