Skip to content

CSV update: use konflux repository for our images #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

littlejawa
Copy link
Contributor

@littlejawa littlejawa commented Feb 28, 2025

Changing the image references to use the konflux repo. This is a temporary measure, to validate konflux's nudging process, where the bundle file gets updated when the images are rebuilt.

We will put back the release registry URL when our release plan is set on the konflux side. Then konflux should be able to update the images with the release URL.

For reference: I am following the instructions from https://konflux-ci.dev/docs/advanced-how-tos/building-olm/#automating-updates-for-image-references-in-the-csv

@openshift-ci openshift-ci bot requested review from pmores and vvoronko February 28, 2025 08:38
@littlejawa
Copy link
Contributor Author

@spotlesstofu @gkurz - It's a pretty simple one, but I don't want to merge without a review :-)
Could you get a look ?

@gkurz
Copy link
Member

gkurz commented Mar 5, 2025

@littlejawa this change is reverted by running make bundle locally. Is it intended or should we patch https://github.com/openshift/sandboxed-containers-operator/blob/devel/config/manager/manager.yaml as well ?

@littlejawa littlejawa force-pushed the update_bundle_references_to_konflux branch from 60627f2 to 84c1aae Compare March 6, 2025 09:08
@littlejawa
Copy link
Contributor Author

littlejawa commented Mar 6, 2025

this change is reverted by running make bundle locally.

@gkurz - Right, I need to update the manager.yaml file too.
I'm also adding another change: the metrics server image was not updated, and it needs to point to the same place.
I'm not sure Konflux will know how to look it up and update though - the document mention the operator's image and related images, but not secondary containers deployed from the same place... We will need to keep an eye out on this when we get CSV updates from konflux after a merge.

Changing the image references to use the konflux repo.
This is a temporary measure, to validate konflux's nudging process,
where the bundle file gets updated when the images are rebuilt.

We will put back the release registry URL when our release plan
is set on the konflux side. Then konflux should be able to update
the images with the release URL.

Signed-off-by: Julien Ropé <[email protected]>
@littlejawa littlejawa force-pushed the update_bundle_references_to_konflux branch from 84c1aae to 1ee4d5d Compare March 6, 2025 13:24
@littlejawa
Copy link
Contributor Author

Updated again with the current reference for the operator - Build was failing because the image didn't exist anymore.

Copy link

openshift-ci bot commented Mar 6, 2025

@littlejawa: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@spotlesstofu spotlesstofu requested a review from Copilot April 18, 2025 07:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements temporary updates to image references for the operator, switching from the Red Hat registry to the konflux repository to validate the nudging process during image rebuilds.

  • Updated image references and digests in config/manager/manager.yaml
  • Revised image references, digests, and operator image in the CSV manifest to align with the konflux repository

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
config/manager/manager.yaml Image references updated to konflux images with new digests
bundle/manifests/sandboxed-containers-operator.clusterserviceversion.yaml CSV updated to reference konflux operator images and related images with new digests
Comments suppressed due to low confidence (2)

config/manager/manager.yaml:80

  • Confirm that the new image digest for the 'osc-monitor' image is correct and aligns with the konflux repository build output.
value: quay.io/redhat-user-workloads/ose-osc-tenant/osc-monitor@sha256:1e19738be039443b1086a22c446897216e791a6cd72da5aeeb6e538f1c9aa447

bundle/manifests/sandboxed-containers-operator.clusterserviceversion.yaml:397

  • Ensure that the updated operator image reference is consistent with the other image changes and that its digest reflects the intended temporary measure.
image: quay.io/redhat-user-workloads/ose-osc-tenant/osc-operator@sha256:7aecfb575e553ec53ccb1880e2f77bb66f48190c49372723882a3ca7d6ba315c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants