Skip to content

Update Samples and configure Swift backend for Glance #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Oct 11, 2024

The unsupported File backend is currently used in most of the samples. They are not consistent even with the documentation, where we suggest to add replicas: 0 to the glance service until a backend is chosen. Considering we have Swift deployed by default, this patch fixes the Glance samples and adds Swift as a backend. This change will be reflected in the openstack-operator guide as well.

@fmount
Copy link
Contributor Author

fmount commented Oct 11, 2024

This change might be required to not mess w/ CI if we land openstack-k8s-operators/glance-operator#440

@fmount fmount force-pushed the glance_swift branch 3 times, most recently from ea995fc to b7e0084 Compare October 14, 2024 09:43
The unsupported File backend is currently used in most of the samples.
They are not consistent even with the documentation, where we suggest to
add replicas: 0 to the glance service until a backend is chosen.
Considering we have Swift deployed by default, this patch fixes the
Glance samples and add Swift as a backend. This change will be
reflected in the openstack-operator guide as well.

Signed-off-by: Francesco Pantano <[email protected]>
@stuggi
Copy link
Contributor

stuggi commented Oct 16, 2024

@fmount this looks good to me. how do you want to proceed? should we get this in? or wait until after the next branching?

@fmount
Copy link
Contributor Author

fmount commented Oct 17, 2024

@fmount this looks good to me. how do you want to proceed? should we get this in? or wait until after the next branching?

Because we're just changing samples, I'm not concerned about landing them at a particular time frame.
+1 to merge this patch and move forward.
Thank you @stuggi for looking at that!

@fmount
Copy link
Contributor Author

fmount commented Oct 17, 2024

/unhold

Copy link
Contributor

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b19d1fe into openstack-k8s-operators:main Oct 23, 2024
8 checks passed
fmount added a commit to fmount/glance-operator that referenced this pull request Oct 28, 2024
As a followup of [1], we need to remove the unnecessary
openstack-operator kustomize patching.

[1] openstack-k8s-operators/openstack-operator#1130

Signed-off-by: Francesco Pantano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants