-
Notifications
You must be signed in to change notification settings - Fork 91
Update Samples and configure Swift backend for Glance #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Samples and configure Swift backend for Glance #1130
Conversation
This change might be required to not mess w/ CI if we land openstack-k8s-operators/glance-operator#440 |
ea995fc
to
b7e0084
Compare
The unsupported File backend is currently used in most of the samples. They are not consistent even with the documentation, where we suggest to add replicas: 0 to the glance service until a backend is chosen. Considering we have Swift deployed by default, this patch fixes the Glance samples and add Swift as a backend. This change will be reflected in the openstack-operator guide as well. Signed-off-by: Francesco Pantano <[email protected]>
@fmount this looks good to me. how do you want to proceed? should we get this in? or wait until after the next branching? |
Because we're just changing samples, I'm not concerned about landing them at a particular time frame. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+2
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b19d1fe
into
openstack-k8s-operators:main
As a followup of [1], we need to remove the unnecessary openstack-operator kustomize patching. [1] openstack-k8s-operators/openstack-operator#1130 Signed-off-by: Francesco Pantano <[email protected]>
The unsupported
File
backend is currently used in most of the samples. They are not consistent even with the documentation, where we suggest to addreplicas: 0
to the glance service until a backend is chosen. Considering we haveSwift
deployed by default, this patch fixes theGlance
samples and addsSwift
as a backend. This change will be reflected in the openstack-operator guide as well.