Skip to content

[golang] bump to golang 1.22 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Apr 25, 2025

  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v1.63.4
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.22-sdk-1.31 (if set)

To test on existing env:

  • update golang to 1.22
  • delete current go.work* files
  • init go work files go work init

Depends-On: openstack-k8s-operators/install_yamls#1051
Depends-On: openstack-k8s-operators/openstack-operator#1411

Jira: OSPRH-12935

stuggi added 2 commits April 25, 2025 10:52
* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v1.63.4
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.22-sdk-1.31

Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <[email protected]>
Signed-off-by: Martin Schuppert <[email protected]>
Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 25, 2025

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/placement-operator-build-deploy-kuttl 823df06 link true /test placement-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant