Skip to content

[PyOV] Migrate from pre-commit git hook to automatic PR for stubs generation #30744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented May 27, 2025

Details:

  • Example PR generated by the GHA job to my fork: [PyOV] Update Python API stub files p-wysocki/openvino#182
  • The PR is automatically generated daily on weekdays
  • The PR can also be generated manually
  • The new GHA job is working correctly on my fork, there may be some corrections needed to get it working on OpenVINO master (for example, in repository settings the ability for GHA to make PRs has to be checked)
  • This approach is miles better than unstable per-dev-machine generation
  • The hook install step has been replaced with hook uninstall step, which will be removed altogether in the future
  • Removed the CI check for keeping the stubs updated

Tickets:

Detailed Copilot PR summary

Removal of pre-commit hook and related scripts:

Introduction of GitHub Actions workflow:

Updates to CI and build configurations:

Documentation updates:

p-wysocki added 7 commits May 27, 2025 10:46
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki p-wysocki added this to the 2025.3 milestone May 27, 2025
@p-wysocki p-wysocki requested review from akuporos and almilosz May 27, 2025 11:29
@p-wysocki p-wysocki requested review from a team as code owners May 27, 2025 11:29
@p-wysocki p-wysocki requested review from kblaszczak-intel and removed request for a team May 27, 2025 11:30
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: Python API OpenVINO Python bindings category: CI OpenVINO public CI category: docs OpenVINO documentation github_actions Pull requests that update GitHub Actions code labels May 27, 2025
Signed-off-by: p-wysocki <[email protected]>
@p-wysocki
Copy link
Contributor Author

For this PR, this check is required in OpenVINO repository:
image
@akladiev is it something that we can turn on?

Copy link
Contributor

@akashchi akashchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA changes LGTM.


- name: Install OpenVINO nightly and stubgen
run: |
python -m pip install --pre -U openvino --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it should be triggered for each commit. How do you expect to update the stub files for the release packages?

@mryzhov mryzhov requested a review from akashchi June 2, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: docs OpenVINO documentation category: Python API OpenVINO Python bindings github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants