-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[PyOV] Migrate from pre-commit git hook to automatic PR for stubs generation #30744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
…into auto_stubs Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: p-wysocki <[email protected]>
Co-authored-by: Alicja Miloszewska <[email protected]>
For this PR, this check is required in OpenVINO repository: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHA changes LGTM.
|
||
- name: Install OpenVINO nightly and stubgen | ||
run: | | ||
python -m pip install --pre -U openvino --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it should be triggered for each commit. How do you expect to update the stub files for the release packages?
Details:
Tickets:
Detailed Copilot PR summary
Removal of pre-commit hook and related scripts:
.github/actions/validate_pyi_files/action.yml
: Removed the action that verified.pyi
files during CI..github/actions/validate_pyi_files/compare_pyi_files.py
: Deleted the script that compared generated.pyi
files with committed ones.src/bindings/python/scripts/stub_generation_precommit.yaml
: Removed the pre-commit hook configuration for.pyi
stub generation.Introduction of GitHub Actions workflow:
.github/workflows/update_pyapi_stubs.yml
: Added a new workflow to generate and update.pyi
stub files automatically on a schedule or via manual triggers.Updates to CI and build configurations:
.github/workflows/job_python_api_tests.yml
: Removed steps related to.pyi
file validation from the Python API tests workflow. [1] [2]src/bindings/python/CMakeLists.txt
: Replaced the installation of the pre-commit hook with its uninstallation, as stub generation is now handled by the GitHub Actions workflow. [1] [2]Documentation updates:
src/bindings/python/docs/stubs.md
: Updated the documentation to reflect the removal of the pre-commit hook and the introduction of the GitHub Actions workflow for stub generation. [1] [2]