[CPU] Apply 'readability-*' clang-tidy remarks #30769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praasz
approved these changes
May 28, 2025
aobolensk
force-pushed
the
readability
branch
10 times, most recently
from
dd0597b to
fbb9452
Compare
aobolensk
force-pushed
the
readability
branch
2 times, most recently
from
99fd92e to
ef264c8
Compare
Comment on lines
+51
to
+62
| # -readability-avoid-nested-conditional-operator | ||
| # -readability-avoid-return-with-void-value | ||
| # -readability-const-return-type | ||
| # -readability-convert-member-functions-to-static | ||
| # -readability-function-cognitive-complexity. Reasonable way to enforce splitting complex code into simple functions | ||
| # -readability-inconsistent-declaration-parameter-name | ||
| # -readability-isolate-declaration | ||
| # -readability-magic-numbers, cppcoreguidelines-avoid-magic-numbers | ||
| # -readability-simplify-boolean-expr | ||
| # -readability-static-accessed-through-instance | ||
| # -readability-suspicious-call-argument | ||
| # -readability-use-anyofallof |
There was a problem hiding this comment.
Which of these are we planning to enable in scope of a follow up commit?
All of them?
There was a problem hiding this comment.
Yes, all of them
Merged
via the queue into
openvinotoolkit:master
with commit May 30, 2025
d1c65e2
220 of 222 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Note: This commit covers the part with of "readability-*" scope that is fixed automatically by
--fixfeature of the toolTickets: