Skip to content

feat: Add support for SHA-512 into the existing SHA-256 VM chip #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

feat: Add support for SHA-512 into the existing SHA-256 VM chip #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
66eab32
Added sha-macros. Derive ColsRef to generate a ColsRef struct
Avaneesh-axiom Feb 6, 2025
ea45bc8
Updated sha256 air to use sha-macros (ColsRef structs)
Avaneesh-axiom Feb 10, 2025
43f3715
Fix typo bug
Avaneesh-axiom Feb 10, 2025
dc8938d
Added sha512 support to the air
Avaneesh-axiom Feb 10, 2025
d743bdc
Updated names
Avaneesh-axiom Feb 12, 2025
926317a
cleanup
Avaneesh-axiom Feb 12, 2025
2f73530
fix rebase issues
Avaneesh-axiom Mar 28, 2025
ef25bdc
Merge ShaPrecomputedValues trait into ShaConfig trait for simplicity
Avaneesh-axiom Feb 13, 2025
d110b70
Generalize ColsRef macro
Avaneesh-axiom Feb 13, 2025
e5caa56
Rename len method of ColsRef structs to width
Avaneesh-axiom Feb 13, 2025
c45ce03
Support SHA-512
Avaneesh-axiom Apr 4, 2025
cc43df8
Add SHA-384 support
Avaneesh-axiom Apr 4, 2025
00b71ea
Fix rebase issue
Avaneesh-axiom Apr 4, 2025
e927567
fix lint errors
Avaneesh-axiom Apr 4, 2025
e27df87
Rename SHA-256 to SHA-2
Avaneesh-axiom Apr 4, 2025
376021b
Rename sha-macros and move it to openvm-circuit-primitives-derive
Avaneesh-axiom Apr 7, 2025
09d6aa0
Update SHA-2 VM extension spec
Avaneesh-axiom Apr 7, 2025
70a559a
Updated the specs
Avaneesh-axiom Apr 7, 2025
6a837f0
Updated the book
Avaneesh-axiom Apr 7, 2025
6c14e5a
Deleted debugging code
Avaneesh-axiom Apr 7, 2025
12321d4
fix lint errors
Avaneesh-axiom Apr 7, 2025
eb79f34
Add documentation for ColsRef macro
Avaneesh-axiom Apr 7, 2025
64b0aaa
lint errors
Avaneesh-axiom Apr 7, 2025
4e2dcdf
Remove old sha macro crate
Avaneesh-axiom Apr 7, 2025
41d90d7
Fix ColsRef macro spec
Avaneesh-axiom Apr 7, 2025
1bab7bf
Replace compile errors with panic in ColsRef macro
Avaneesh-axiom Apr 7, 2025
2df8c2a
Minor wording changes
Avaneesh-axiom Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/extension-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- { name: "rv32im", path: "rv32im" }
- { name: "native", path: "native" }
- { name: "keccak256", path: "keccak256" }
- { name: "sha256", path: "sha256" }
- { name: "sha2", path: "sha2" }
- { name: "bigint", path: "bigint" }
- { name: "algebra", path: "algebra" }
- { name: "ecc", path: "ecc" }
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/primitives.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
paths:
- "crates/circuits/primitives/**"
- "crates/circuits/poseidon2-air/**"
- "crates/circuits/sha256-air/**"
- "crates/circuits/sha2-air/**"
- "crates/circuits/mod-builder/**"
- "Cargo.toml"
- ".github/workflows/primitives.yml"
Expand Down Expand Up @@ -47,8 +47,8 @@ jobs:
run: |
cargo nextest run --cargo-profile fast --features parallel

- name: Run tests for sha256-air
working-directory: crates/circuits/sha256-air
- name: Run tests for sha2-air
working-directory: crates/circuits/sha2-air
run: |
cargo nextest run --cargo-profile fast --features parallel

Expand Down
Loading
Loading