Skip to content

feat: Add SHA-512 and SHA-384 support to the SHA-256 VM extension #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Avaneesh-axiom
Copy link
Contributor

@Avaneesh-axiom Avaneesh-axiom commented Apr 7, 2025

Note to reviewer: the Github PR review UI doesn't diff some files properly across renaming despite my best efforts. For example, crates/circuits/sha256-air/src/air.rs -> crates/circuits/sha-air/src/air.rs isn't detected and it shows as deletion of the old file and creation of the new one. To make the review easier, consider reviewing each commit one at a time. The diffs work nicer that way.

Closes INT-3211 and INT-3213

@Avaneesh-axiom Avaneesh-axiom changed the base branch from main to develop April 7, 2025 22:40

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Apr 7, 2025

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-5 [-0.4%]) 1,270 334,142 17,677,298 - - -
fibonacci_program (+7 [+0.3%]) 2,704 1,500,277 50,589,503 - - -
regex_program (+110 [+1.4%]) 8,165 4,165,226 166,511,152 - - -
ecrecover_program (-36 [-2.5%]) 1,418 289,447 14,470,186 - - -
pairing (-141 [-2.9%]) 4,791 1,820,436 95,832,407 - - -

Commit: 6fc3985

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants