feat: GKR LogUp

.github/workflows/benchmarks-execute.yml

@@ -0,0 +1,112 @@
+name: "benchmarks-execute"
+
+on:
+  push:
+    branches: ["main"]
+  pull_request:
+    types: [opened, synchronize, reopened, labeled]
+    branches: ["**"]
+    paths:
+      - "benchmarks/execute/**"
+      - "crates/circuits/**"
+      - "crates/toolchain/**"
+      - "crates/prof/**"
+      - "crates/sdk/**"
+      - "crates/vm/**"
+      - "extensions/**"
+      - "Cargo.toml"
+      - ".github/workflows/benchmarks-execute.yml"
+  workflow_dispatch:
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  execute-benchmarks:
+    runs-on:
+      - runs-on=${{ github.run_id }}
+      - runner=8cpu-linux-x64
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+
+      - name: Run execution benchmarks
+        working-directory: benchmarks/execute
+        run: cargo run | tee benchmark_output.log
+
+      - name: Parse benchmark results
+        working-directory: benchmarks/execute
+        run: |
+          # Determine if running in GitHub Actions environment
+          if [ -n "$GITHUB_STEP_SUMMARY" ]; then
+            SUMMARY_FILE="$GITHUB_STEP_SUMMARY"
+            echo "### Benchmark Results Summary" >> "$SUMMARY_FILE"
+          else
+            SUMMARY_FILE="benchmark_summary.md"
+            echo "### Benchmark Results Summary" > "$SUMMARY_FILE"
+            echo "Saving summary to $SUMMARY_FILE"
+          fi
+
+          # Set up summary table header
+          echo "| Program | Total Time (ms) |" >> "$SUMMARY_FILE"
+          echo "| ------- | --------------- |" >> "$SUMMARY_FILE"
+
+          # Variables to track current program and total time
+          current_program=""
+          total_time=0
+
+          # Process the output file line by line
+          while IFS= read -r line; do
+            # Check if line contains "Running program" message
+            if [[ $line =~ ｉ\ \[info\]:\ Running\ program:\ ([a-zA-Z0-9_-]+) ]]; then
+              # If we were processing a program, output its results
+              if [[ -n "$current_program" ]]; then
+                echo "| $current_program | $total_time |" >> "$SUMMARY_FILE"
+              fi
+
+              # Start tracking new program
+              current_program="${BASH_REMATCH[1]}"
+              total_time=0
+            fi
+
+            # Check for program completion to catch programs that might have no execution segments
+            if [[ $line =~ ｉ\ \[info\]:\ Completed\ program:\ ([a-zA-Z0-9_-]+) ]]; then
+              completed_program="${BASH_REMATCH[1]}"
+              # If no segments were found for this program, ensure it's still in the output
+              if [[ "$current_program" == "$completed_program" && $total_time == 0 ]]; then
+                echo "| $current_program | 0 |" >> "$SUMMARY_FILE"
+                current_program=""
+              fi
+            fi
+
+            # Check if line contains execution time (looking for the format with ms or s)
+            if [[ $line =~ execute_segment\ \[\ ([0-9.]+)(ms|s)\ \|\ [0-9.]+%\ \]\ segment ]]; then
+              segment_time="${BASH_REMATCH[1]}"
+              unit="${BASH_REMATCH[2]}"
+
+              # Convert to milliseconds if in seconds
+              if [[ "$unit" == "s" ]]; then
+                segment_time=$(echo "scale=6; $segment_time * 1000" | bc)
+              fi
+
+              # Add segment time to total
+              total_time=$(echo "scale=6; $total_time + $segment_time" | bc)
+            fi
+          done < benchmark_output.log
+
+          # Output the last program result if there was one
+          if [[ -n "$current_program" ]]; then
+            echo "| $current_program | $total_time |" >> "$SUMMARY_FILE"
+          fi
+
+          # If not in GitHub Actions, print the summary to the terminal
+          if [ -z "$GITHUB_STEP_SUMMARY" ]; then
+            echo -e "\nBenchmark Summary:"
+            cat "$SUMMARY_FILE"
+          fi

.github/workflows/benchmarks.yml

@@ -7,7 +7,7 @@ on:
     types: [opened, synchronize, reopened, labeled]
     branches: ["**"]
     paths:
-      - "benchmarks/**"
+      - "benchmarks/prove/**"
       - "crates/circuits/**"
       - "crates/toolchain/**"
       - "crates/prof/**"

.github/workflows/cli.yml

@@ -12,6 +12,7 @@ on:
       - "crates/cli/**"
       - "examples/**"
       - "Cargo.toml"
+      - ".github/workflows/cli.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
@@ -39,10 +40,6 @@ jobs:
       - name: Install solc # svm should support arm64 linux
         run: (hash svm 2>/dev/null || cargo install --version 0.2.23 svm-rs) && svm install 0.8.19 && solc --version
 
-      - name: Install tools
-        run: |
-          rustup component add rust-src --toolchain nightly-2025-02-14
-
       - name: Install cargo-openvm
         working-directory: crates/cli
         run: |
@@ -74,3 +71,8 @@ jobs:
           export RUST_BACKTRACE=1
           cargo build
           cargo run --bin cargo-openvm -- openvm keygen --config ./example/app_config.toml --output app.pk --vk-output app.vk
+
+      - name: Run CLI tests
+        working-directory: crates/cli
+        run: |
+          cargo nextest run --cargo-profile=fast

.github/workflows/lints.yml

@@ -15,7 +15,7 @@ jobs:
     name: Lint
     runs-on:
       - runs-on=${{ github.run_id }}
-      - runner=8cpu-linux-x64
+      - runner=64cpu-linux-x64
       - extras=s3-cache
     steps:
       - uses: runs-on/action@v1
@@ -45,8 +45,8 @@ jobs:
         run: |
           # list of features generated using:
           # echo -e "\033[1;32mAll unique features across workspace:\033[0m" && cargo metadata --format-version=1 --no-deps | jq -r '.packages[].features | to_entries[] | .key' | sort -u | sed 's/^/• /'
-          cargo clippy --all-targets --all --tests --features "aggregation bench-metrics bls12_381 bn254 default entrypoint export-getrandom export-libm function-span getrandom halo2-compiler halo2curves heap-embedded-alloc k256 mimalloc nightly-features panic-handler parallel rust-runtime static-verifier std test-utils unstable" -- -D warnings
-          cargo clippy --all-targets --all --tests --no-default-features --features "jemalloc jemalloc-prof" -- -D warnings
+          cargo clippy --all-targets --all --tests --features "aggregation bench-metrics bls12_381 bn254 default entrypoint evm-prove evm-verify export-getrandom export-libm function-span getrandom halo2-compiler halo2curves heap-embedded-alloc k256 jemalloc jemalloc-prof nightly-features panic-handler parallel rust-runtime static-verifier std test-utils unstable" -- -D warnings
+          cargo clippy --all-targets --all --tests --no-default-features --features "mimalloc" -- -D warnings
 
       - name: Run fmt, clippy for guest
         run: |

.github/workflows/native-compiler.yml

@@ -10,6 +10,7 @@ on:
       - "extensions/native/circuit/**"
       - "extensions/native/compiler/**"
       - "Cargo.toml"
+      - ".github/workflows/native-compiler.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}

.github/workflows/pr-title.yml

@@ -0,0 +1,83 @@
+# Copied from https://github.com/paradigmxyz/reth/blob/a5755f72eb54d2c88d6f0b5778413144451e1724/.github/workflows/pr-title.yml
+name: Pull Request
+
+on:
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - edited
+      - synchronize
+
+permissions:
+  pull-requests: read
+  contents: read
+
+jobs:
+  conventional-title:
+    name: Validate PR title is Conventional Commit
+    runs-on:
+      - runs-on=${{ github.run_id }}
+      - runner=8cpu-linux-x64
+    permissions:
+      pull-requests: write
+    steps:
+      - name: Check title
+        id: lint_pr_title
+        uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          types: |
+            fix
+            feat
+            chore
+            test
+            perf
+            refactor
+            docs
+            ci
+        continue-on-error: true
+      - name: Add PR Comment for Invalid Title
+        if: steps.lint_pr_title.outcome == 'failure'
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          header: pr-title-lint-error
+          message: |
+            Your PR title doesn't follow the Conventional Commit guidelines.
+
+            **Example of valid titles:**
+            - `feat: add new user login`
+            - `fix: correct button size`
+            - `docs: update README`
+
+            **Usage:**
+            - `feat`: Introduces a new feature
+            - `fix`: Patches a bug
+            - `chore`: General maintenance tasks or updates
+            - `test`: Adding new tests or modifying existing tests
+            - `perf`: Performance improvements
+            - `refactor`: Changes to improve code structure
+            - `docs`: Documentation updates
+            - `ci`: Changes to CI/CD configurations
+
+            **Breaking Changes**
+
+            Breaking changes are noted by using an exclamation mark. For example:
+            - `feat!: changed the API`
+            - `chore(node)!: Removed unused public function`
+
+            **Help**
+
+            For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/
+
+      - name: Remove Comment for Valid Title
+        if: steps.lint_pr_title.outcome == 'success'
+        uses: marocchino/sticky-pull-request-comment@v2
+        with:
+          header: pr-title-lint-error
+          delete: true
+
+      - name: Fail workflow if title invalid
+        if: steps.lint_pr_title.outcome == 'failure'
+        run: exit 1

.github/workflows/primitives.yml

@@ -9,7 +9,9 @@ on:
       - "crates/circuits/primitives/**"
       - "crates/circuits/poseidon2-air/**"
       - "crates/circuits/sha256-air/**"
+      - "crates/circuits/mod-builder/**"
       - "Cargo.toml"
+      - ".github/workflows/primitives.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
@@ -49,3 +51,8 @@ jobs:
         working-directory: crates/circuits/sha256-air
         run: |
           cargo nextest run --cargo-profile fast --features parallel
+
+      - name: Run tests for mod-builder
+        working-directory: crates/circuits/mod-builder
+        run: |
+          cargo nextest run --cargo-profile fast --features parallel

.github/workflows/recursion.yml

@@ -11,6 +11,7 @@ on:
       - "extensions/native/compiler/**"
       - "extensions/native/recursion/**"
       - "Cargo.toml"
+      - ".github/workflows/recursion.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}

.github/workflows/sdk.yml

@@ -10,6 +10,7 @@ on:
       - "crates/vm/**"
       - "crates/sdk/**"
       - "Cargo.toml"
+      - ".github/workflows/sdk.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
@@ -38,6 +39,9 @@ jobs:
       - name: Install solc # svm should support arm64 linux
         run: (hash svm 2>/dev/null || cargo install --version 0.2.23 svm-rs) && svm install 0.8.19 && solc --version
 
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+
       - name: Install architecture specific tools
         run: |
           arch=$(uname -m)
@@ -73,8 +77,24 @@ jobs:
         run: |
           bash ../../extensions/native/recursion/trusted_setup_s3.sh
 
+      - name: Run openvm-sdk contracts/ tests
+        working-directory: crates/sdk/contracts
+        run: |
+          forge fmt --check
+          forge build --sizes
+          forge test
+
+      - name: Check IOpenVmHalo2Verifier.sol abi correctness
+        working-directory: crates/sdk/contracts
+        run: |
+          forge build
+          jq -S '.abi' ./out/IOpenVmHalo2Verifier.sol/IOpenVmHalo2Verifier.json > compiled_abi.json
+          jq -S . ./abi/IOpenVmHalo2Verifier.json > expected_abi_sorted.json
+          diff -u expected_abi_sorted.json compiled_abi.json
+
       - name: Run openvm-sdk crate tests
         working-directory: crates/sdk
         run: |
           export RUST_BACKTRACE=1
           cargo nextest run --cargo-profile=fast --test-threads=2 --features parallel
+

.github/workflows/vm.yml

@@ -10,6 +10,7 @@ on:
       - "crates/vm/**"
       - "extensions/native/**"
       - "Cargo.toml"
+      - ".github/workflows/vm.yml"
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}

.gitignore

@@ -22,6 +22,7 @@ rustc-*
 # Bench metrics
 .bench_metrics/
 __pycache__/
+metrics.json
 
 # KZG trusted setup
 **/params
@@ -32,3 +33,6 @@ __pycache__/
 # Profiling
 **/flamegraph.svg
 **/profile.json
+
+# openvm generated files
+crates/cli/openvm/

.gitmodules

@@ -1,3 +1,6 @@
 [submodule "toolchain/tests/rv32im-test-vectors/riscv-tests"]
 	path = crates/toolchain/tests/rv32im-test-vectors/riscv-tests
 	url = https://github.com/riscv-software-src/riscv-tests.git
+[submodule "crates/sdk/contracts/lib/forge-std"]
+	path = crates/sdk/contracts/lib/forge-std
+	url = https://github.com/foundry-rs/forge-std