feat: Macro define_verify_openvm_stark #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
c316819 to
3d10170
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
3d10170 to
1402e28
Compare
nyunyunyunyu
force-pushed
the
feat/root-dsl-asm
branch
from
f214f43 to
c1829fc
Compare
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
1402e28 to
78f0f29
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
78f0f29 to
fd2cc4d
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
changed the title
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
fd2cc4d to
25061e4
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/root-dsl-asm
branch
2 times, most recently
from
906e765 to
e56163d
Compare
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
25061e4 to
d946854
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
d946854 to
70a005c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
a9d152f to
7b2dd5c
Compare
This comment has been minimized.
This comment has been minimized.
docs/specs/RISCV.md
Outdated
| @@ -72,6 +72,10 @@ the guest must take care to validate all data and account for behavior in cases | |||
| | printstr | I | 0001011 | 011 | 0x1 | Tries to convert `[rd..rd + rs1]_2` to UTF-8 string and print to host stdout. Will print error message if conversion fails. | | |||
| | hintrandom | I | 0001011 | 011 | 0x2 | Resets the hint stream to `4 * rd` random bytes from `rand::rngs::OsRng` on the host. | | |||
|
|
|||
| | RISC-V Inst | FMT | opcode[6:0] | funct3 | funct7 | RISC-V description and notes | | |||
| |--------------|-----|-------------|---------|---------|---------------------------------------------------------------------------------------------------------------------------------| | |||
| | nativestorew | R | 0001011 | 111 | 2 | Stores the 4-byte word `rs1` at address `rd` in native address space. The address `rd` must be aligned to a 4-byte boundary. | | |||
There was a problem hiding this comment.
Suggested change
| | nativestorew | R | 0001011 | 111 | 2 | Stores the 4-byte word `rs1` at address `rd` in native address space. The address `rd` must be aligned to a 4-byte boundary. | | |
| | nativestorew | R | 0001011 | 111 | 0x2 | Stores the 4-byte word `rs1` at address `rd` in native address space. The address `rd` must be aligned to a 4-byte boundary. | |
nit: for consistency
| (RV32_REGISTER_NUM_LIMBS * dec_insn.rs1) as isize, | ||
| (RV32_REGISTER_NUM_LIMBS * dec_insn.rd) as isize, | ||
| 0, | ||
| 1, |
There was a problem hiding this comment.
do we have constant for this addr space?
| .map(|x| x as u32) | ||
| .collect(); | ||
|
|
||
| let key = ASM_FILENAME |
There was a problem hiding this comment.
why is the filename part of the key?
and if it is part of the key, why the base filename and not the full path?
| /// little-endian bytes. | ||
| #[macro_export] | ||
| macro_rules! define_verify_openvm_stark { | ||
| ($fn_name: ident, $asm_folder: expr, $asm_filename: literal) => { |
There was a problem hiding this comment.
why the separation between folder vs filename?
There was a problem hiding this comment.
Well I didn't figure out how to split a constant string in macro at compile time
There was a problem hiding this comment.
I meant why did you need the key to just be the filename
There was a problem hiding this comment.
Ah it's more friendly to add inputs into key-value store. "/usr/abc/xxx/verifier.asm" is much more weird than "verifier.asm"...
jonathanpwang
approved these changes
May 9, 2025
nyunyunyunyu
force-pushed
the
feat/verify_e2e_stark
branch
from
b10d91f to
d7a1322
Compare
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
7b2dd5c to
e539dd3
Compare
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
from
e539dd3 to
66d85df
Compare
Commit: 66d85df |
nyunyunyunyu
added a commit
that referenced
this pull request
May 15, 2025
- Add a RISC-V custom instruction `nativestorew` into `Rv32IoTranspilerExtension`. - Add macro `define_verify_openvm_stark`, which can define a function for guest program to verify a stark proof. closes INT-3896
jonathanpwang
pushed a commit
that referenced
this pull request
May 16, 2025
- Add a RISC-V custom instruction `nativestorew` into `Rv32IoTranspilerExtension`. - Add macro `define_verify_openvm_stark`, which can define a function for guest program to verify a stark proof. closes INT-3896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativestorewintoRv32IoTranspilerExtension.define_verify_openvm_stark, which can define a function for guest program to verify a stark proof.closes INT-3896