-
Notifications
You must be signed in to change notification settings - Fork 58
release: v1.2.1-rc.0 #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jonathanpwang
wants to merge
14
commits into
main
Choose a base branch
from
release-v1.2.1-rc.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
release: v1.2.1-rc.0 #1646
+3,436
−1,247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `max_num_public_values` in `Program`/`Elf`. - Improve serialization/deserialization of `Program`. For a Program with 100,000 instructions: Previous: - Serialize: 3.1969ms - Deserialize: 3.2417ms - Size: 3625020 bytes Now: - Serialize: 1.3015ms - Deserialize: 1.9343ms - Size: 4000024 bytes closes INT-3131 closes INT-3771
Added a build script that automatically adds calls to `moduli_init, complex_init, sw_init` appropriately by reading the vm config.
…1603) We no longer need to manually call `setup_*` at the start of main for the moduli and curves. Instead, setup is automatically done on first use of each modulus or curve. Depends on #1596 --------- Co-authored-by: Jonathan Wang <[email protected]>
delete getrandom dependency from platform since getrandom now makes enabling of the custom backend opt-in via extern function and --cfg flag closes INT-3934
This comment has been minimized.
This comment has been minimized.
…ons (#1647) Resolves INT-4000, INT-3883, and INT-3662. In general, we would like `cargo openvm build` to align as closely with `cargo build` as possible. OpenVM users should be able to almost completely replace the latter with the former in their development workflows. Implements the following: - Parity between `cargo openvm build` and `cargo build` options - Ability to build multiple targets when building at the workspace level - `cargo openvm build` works outside of project root - Default paths in OpenVM CLI evaluate environment variable `HOME` at runtime OpenVM-generated artifacts being stored in `${CARGO_TARGET_DIR}/.openvm` is still to be implemented, but in order to maintain coherency between `cargo openvm build` and `cargo openvm run/prove` this change will be added later.
This comment has been minimized.
This comment has been minimized.
- Add new type `E2eStarkProof` as the format of the final internal proof. `E2eStarkProof` supports `Encode` so it can be deserialized in other languages. - Add function `wrap_e2e_stark_proof` to wrap the final internal proof to `RootVerifierInput`. - Add `cargo openvm prove stark` to generate e2e stark proof. closes INT-3784
- Add `kv_store` into `Streams`. More details at `docs/specs/ISA.md`. - Add a new phantom instruction `Rv32HintLoadByKey` which can hint data based on a key at runtime. More details at `docs/specs/ISA.md`. - SDK support will be added in the future PRs. close INT-3893
- Add a function `build_kernel_asm` into `RootVmVerifierConfig`. The generated ASM can be used in kernel functions for guest program to verify starks. More details could be found in the doc comments of the function. - Fix a confusing naming. `num_public_values` is actually the number of user public values instead of the number of public values of the proof. Use `num_user_public_values` instead. closes INT-3894
- Add a RISC-V custom instruction `nativestorew` into `Rv32IoTranspilerExtension`. - Add macro `define_verify_openvm_stark`, which can define a function for guest program to verify a stark proof. closes INT-3896
- `AppExecutionCommit` stores `u32` instead of `BabyBear`. - Rename `E2eStarkProof` to `VmStarkProof`. - Add `compute_hint_key_for_verify_openvm_stark`/`encode_rv32_public_values` for users to prepare inputs for `verify_openvm_stark`. But it still seems hard to understand what happens. - Improve docs about `Rv32HintLoadByKey`.
- `cargo openvm setup` supports skipping halo2 proving keys. - `cargo openvm setup` outputs halo2 PK and stark PK as separated files. - `cargo openvm build` outputs `AppExecutionCommit` in json. The old output(`exe_commit.bytes`) was incorrect. close INT-3950
This comment has been minimized.
This comment has been minimized.
Fixes the path from which verifier contract is read. I tested the full CI flow on an aws instance to double check everything is working.
This comment has been minimized.
This comment has been minimized.
Adds CHANGELOG.md to the repo. - [x] CHANGELOG notes for `v1.1.0` to be added --------- Co-authored-by: Jonathan Wang <[email protected]>
This comment has been minimized.
This comment has been minimized.
Resolves INT-4065.
Commit: 274c422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be rebase merged