-
Notifications
You must be signed in to change notification settings - Fork 58
feat: e1,e3 implementation for sha2 #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/new-execution
Are you sure you want to change the base?
Conversation
…inor improvements
CodSpeed Instrumentation Performance ReportMerging #1657 will not alter performanceComparing Summary
|
CodSpeed Walltime Performance ReportMerging #1657 will not alter performanceComparing
|
@arayikhalatyan we shouldn't have any block size restrictions on E1 (but likely need it for E2 in some light form). My imagination is indeed that E1 should just look like |
Yeah I agree. Then we have to make some changes to the GuestMemory interface because it expects the block size as a const generic. |
Implemented e1, e3 for sha2 circuit. I feel like the trace generation of sha2 is more readable now. Probably there is a room for making the inner sha256 trace generation more efficient, I'll try to make some improvements before merging.
Question: are we planning to have the restrictions on
block_size
(eg alignment and being power of two) in e1 and does it have to be constant? If not I could make the e1 execution to read the entire message in one read.Resolves INT-3966